yank: Check for bad version & added error message for prefixed v in version

Author: Pyr0de

src/bin/cargo/commands/yank.rs

@@ -1,5 +1,6 @@
 use crate::command_prelude::*;
 
+use anyhow::Context;
 use cargo::ops;
 use cargo_credential::Secret;
 
@@ -60,5 +61,19 @@ fn resolve_crate<'k>(
         krate = Some(k);
         version = Some(v);
     }
+
+    if let Some(version) = version {
+        semver::Version::parse(version).with_context(|| {
+            if let Some(stripped) = version.strip_prefix("v") {
+                return format!(
+                    "the version provided, `{version}` is not a \
+                    valid SemVer version\n\n\
+                    help: try changing the version to `{stripped}`",
+                );
+            }
+            format!("invalid version `{version}`")
+        })?;
+    }
+
     Ok((krate, version))
 }

tests/testsuite/yank.rs

@@ -237,12 +237,10 @@ fn bad_version() {
         .replace_crates_io(registry.index_url())
         .with_status(101)
         .with_stderr_data(str![[r#"
-[UPDATING] crates.io index
-[YANK] foo@bar
-[ERROR] failed to yank from the registry at [ROOTURL]/api
+[ERROR] invalid version `bar`
 
 Caused by:
-  [37] Couldn't read a file:// file (Couldn't open file [ROOT]/api/api/v1/crates/foo/bar/yank)
+  unexpected character 'b' while parsing major version number
 
 "#]])
         .run();
@@ -272,12 +270,12 @@ fn prefixed_v_in_version() {
         .replace_crates_io(registry.index_url())
         .with_status(101)
         .with_stderr_data(str![[r#"
-[UPDATING] crates.io index
-[YANK] [email protected]
-[ERROR] failed to yank from the registry at [ROOTURL]/api
+[ERROR] the version provided, `v0.0.1` is not a valid SemVer version
+
+[HELP] try changing the version to `0.0.1`
 
 Caused by:
-  [37] Couldn't read a file:// file (Couldn't open file [ROOT]/api/api/v1/crates/bar/v0.0.1/yank)
+  unexpected character 'v' while parsing major version number
 
 "#]])
         .run();