Skip to content

Commit 7d4e39c

Browse files
committed
fix(embedded): Don't generate empty package names
1 parent 87be661 commit 7d4e39c

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

src/cargo/util/restricted_names.rs

+3
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ pub fn sanitize_package_name(name: &str, placeholder: char) -> String {
100100
slug.push(placeholder);
101101
}
102102
}
103+
if slug.is_empty() {
104+
slug.push_str("package");
105+
}
103106
slug
104107
}
105108

tests/testsuite/script.rs

+8-5
Original file line numberDiff line numberDiff line change
@@ -574,13 +574,16 @@ fn test_name_is_number() {
574574

575575
p.cargo("-Zscript -v 42.rs")
576576
.masquerade_as_nightly_cargo(&["script"])
577-
.with_status(101)
577+
.with_stdout(
578+
r#"bin: [..]/debug/package[EXE]
579+
args: []
580+
"#,
581+
)
578582
.with_stderr(
579583
r#"[WARNING] `package.edition` is unspecifiead, defaulting to `2021`
580-
[ERROR] failed to parse manifest at `[ROOT]/foo/42.rs`
581-
582-
Caused by:
583-
package name cannot be an empty string
584+
[COMPILING] package v0.0.0 ([ROOT]/foo)
585+
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]s
586+
[RUNNING] `[..]/debug/package[EXE]`
584587
"#,
585588
)
586589
.run();

0 commit comments

Comments
 (0)