Move all clippy config to target top files

Author: dwijnand

src/bin/cargo/main.rs

@@ -1,5 +1,5 @@
-// we have lots of arguments, cleaning this up would be a large project
-#![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
+#![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] // large project
+#![cfg_attr(feature = "cargo-clippy", allow(redundant_closure))]  // there's a false positive
 
 extern crate cargo;
 extern crate clap;
@@ -135,7 +135,6 @@ fn find_closest(config: &Config, cmd: &str) -> Option<String> {
 
 fn execute_external_subcommand(config: &Config, cmd: &str, args: &[&str]) -> CliResult {
     let command_exe = format!("cargo-{}{}", cmd, env::consts::EXE_SUFFIX);
-    #[cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] // false positive
     let path = search_directories(config)
         .iter()
         .map(|dir| dir.join(&command_exe))

src/cargo/core/compiler/job.rs

@@ -19,8 +19,6 @@ trait FnBox<A, R> {
 }
 
 impl<A, R, F: FnOnce(A) -> R> FnBox<A, R> for F {
-    // False positive: https://github.com/rust-lang-nursery/rust-clippy/issues/1123
-    #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))]
     fn call_box(self: Box<F>, a: A) -> R {
         (*self)(a)
     }

src/cargo/core/manifest.rs

@@ -17,8 +17,6 @@ use util::errors::*;
 use util::toml::TomlManifest;
 use util::Config;
 
-// While unfortunate, resolving the size difference with Box would be a large project
-#[cfg_attr(feature = "cargo-clippy", allow(large_enum_variant))]
 pub enum EitherManifest {
     Real(Manifest),
     Virtual(VirtualManifest),
@@ -207,7 +205,6 @@ struct NonHashedPathBuf {
     path: PathBuf,
 }
 
-#[cfg_attr(feature = "cargo-clippy", allow(derive_hash_xor_eq))] // current intentional incoherence
 impl Hash for NonHashedPathBuf {
     fn hash<H: Hasher>(&self, _: &mut H) {
         // ...

src/cargo/core/profiles.rs

@@ -495,8 +495,6 @@ impl Profile {
     /// Compare all fields except `name`, which doesn't affect compilation.
     /// This is necessary for `Unit` deduplication for things like "test" and
     /// "dev" which are essentially the same.
-    // The complexity of the result type is exempted because it's limited in scope.
-    #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
     fn comparable(
         &self,
     ) -> (

src/cargo/core/resolver/mod.rs

@@ -106,8 +106,6 @@ mod types;
 ///
 /// * `print_warnings` - whether or not to print backwards-compatibility
 ///   warnings and such
-// While unfortunate, generalising this over different hashers would be a large project
-#[cfg_attr(feature = "cargo-clippy", allow(implicit_hasher))]
 pub fn resolve(
     summaries: &[(Summary, Method)],
     replacements: &[(PackageIdSpec, Dependency)],

src/cargo/core/workspace.rs

@@ -87,8 +87,6 @@ struct Packages<'cfg> {
 }
 
 #[derive(Debug)]
-// While unfortunate, resolving the size difference with Box would be a large project
-#[cfg_attr(feature = "cargo-clippy", allow(large_enum_variant))]
 enum MaybePackage {
     Package(Package),
     Virtual(VirtualManifest),

src/cargo/lib.rs

@@ -1,17 +1,18 @@
 #![cfg_attr(test, deny(warnings))]
-// Currently, Cargo does not use clippy for its source code.
-// But if someone runs it they should know that
-// @alexcrichton disagree with clippy on some style things
-#![cfg_attr(feature = "cargo-clippy", allow(explicit_iter_loop))]
-#![cfg_attr(feature = "cargo-clippy", allow(explicit_into_iter_loop))]
-// also we use closures as an alternative to try catch blocks
-#![cfg_attr(feature = "cargo-clippy", allow(redundant_closure_call))]
-
-// we have lots of arguments, cleaning this up would be a large project
-#![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
-
-// we have some complicated functions, cleaning this up would be a large project
-#![cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))]
+
+// Clippy isn't enforced by CI, and know that @alexcrichton isn't a fan :)
+#![cfg_attr(feature = "cargo-clippy", allow(boxed_local))]             // bug rust-lang-nursery/rust-clippy#1123
+#![cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))]   // large project
+#![cfg_attr(feature = "cargo-clippy", allow(derive_hash_xor_eq))]      // there's an intentional incoherence
+#![cfg_attr(feature = "cargo-clippy", allow(explicit_into_iter_loop))] // (unclear why)
+#![cfg_attr(feature = "cargo-clippy", allow(explicit_iter_loop))]      // (unclear why)
+#![cfg_attr(feature = "cargo-clippy", allow(identity_op))]             // used for vertical alignment
+#![cfg_attr(feature = "cargo-clippy", allow(implicit_hasher))]         // large project
+#![cfg_attr(feature = "cargo-clippy", allow(large_enum_variant))]      // large project
+#![cfg_attr(feature = "cargo-clippy", allow(redundant_closure_call))]  // closures over try catch blocks
+#![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]      // large project
+#![cfg_attr(feature = "cargo-clippy", allow(type_complexity))]         // there's an exceptionally complex type
+#![cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))]   // perhaps Rc should be special cased in Clippy?
 
 extern crate atty;
 extern crate clap;

src/cargo/ops/resolve.rs

@@ -133,8 +133,6 @@ fn resolve_with_registry<'cfg>(
 ///
 /// The previous resolve normally comes from a lockfile. This function does not
 /// read or write lockfiles from the filesystem.
-// While unfortunate, generalising this over different hashers would be a large project
-#[cfg_attr(feature = "cargo-clippy", allow(implicit_hasher))]
 pub fn resolve_with_previous<'a, 'cfg>(
     registry: &mut PackageRegistry<'cfg>,
     ws: &Workspace<'cfg>,

src/cargo/util/hex.rs

@@ -4,7 +4,6 @@ use hex;
 use std::hash::{Hash, Hasher, SipHasher};
 
 pub fn to_hex(num: u64) -> String {
-    #[cfg_attr(feature = "cargo-clippy", allow(identity_op))] // don't hate on vertical alignment, clippy
     hex::encode(&[
         (num >> 0) as u8,
         (num >> 8) as u8,

src/cargo/util/toml/mod.rs

@@ -151,8 +151,6 @@ type TomlBenchTarget = TomlTarget;
 
 #[derive(Debug, Serialize)]
 #[serde(untagged)]
-// While unfortunate, resolving the size difference with Box would be a large project
-#[cfg_attr(feature = "cargo-clippy", allow(large_enum_variant))]
 pub enum TomlDependency {
     Simple(String),
     Detailed(DetailedTomlDependency),
@@ -741,7 +739,6 @@ impl TomlManifest {
         }
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] // perhaps Rc should be special cased in Clippy?
     fn to_real_manifest(
         me: &Rc<TomlManifest>,
         source_id: &SourceId,
@@ -997,7 +994,6 @@ impl TomlManifest {
         Ok((manifest, nested_paths))
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] // perhaps Rc should be special cased in Clippy?
     fn to_virtual_manifest(
         me: &Rc<TomlManifest>,
         source_id: &SourceId,

src/crates-io/lib.rs

@@ -1,4 +1,5 @@
 #![allow(unknown_lints)]
+#![cfg_attr(feature = "cargo-clippy", allow(identity_op))] // used for vertical alignment
 
 extern crate curl;
 #[macro_use]
@@ -159,7 +160,6 @@ impl Registry {
         //      <le u32 of tarball>
         //      <source tarball>
         let stat = tarball.metadata()?;
-        #[cfg_attr(feature = "cargo-clippy", allow(identity_op))] // don't hate on vertical alignment, clippy
         let header = {
             let mut w = Vec::new();
             w.extend(