Skip to content

Conversation

steveklabnik
Copy link
Contributor

This isn't 100% ready to ship, as I need to run thanks still, so the number is wrong.

I wonder if it's not a bit too long, especially the diagnostic bit.

r? @rust-lang/core


[can show off your TravisCI or Appveyor badges]: https://github.com/rust-lang/cargo/pull/3546

In addition, both Cargo and crates.io [understand categories]. Unlike keywords, which are free-form,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably deserves a more prominent mention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be up at the top then, maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of this section? I'm not sure. It just felt a bit buried.

But reflecting more, I'm not sure the front-end experience is quite where we want it to make a "big splash" here, so maybe a passing mention is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I'm happy to move it wherever, to be honest.

@aturon
Copy link
Contributor

aturon commented Mar 15, 2017

Looks great! I don't think it's too long -- just plenty to talk about :-)

[This now happens nearly everywhere]: https://github.com/rust-lang/rust/pull/38927
[some other related improvements]: https://github.com/rust-lang/rust/pull/38154

Finally, `Self` can now appear [in impl headers] and [in struct expressions].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self in impl headers rarely works in 1.16
The final piece was landed in rust-lang/rust#40008, so it will be fully available only in 1.17

@brson brson merged commit f31c035 into gh-pages Mar 16, 2017
@steveklabnik steveklabnik deleted the 1.16-announcement branch March 16, 2017 17:30
@@ -201,11 +201,6 @@ results in a significant improvement in these sorts of diagnostics.
[This now happens nearly everywhere]: https://github.com/rust-lang/rust/pull/38927
[some other related improvements]: https://github.com/rust-lang/rust/pull/38154

Finally, `Self` can now appear [in impl headers] and [in struct expressions].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveklabnik
My comment was only about impl headers, Self in struct expressions (Self { a: 10 }) is fully supported in 1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants