Merge pull request #10 from dpaoliello/basictests

Add tests: round-trip with object, and compare to llvm-ar

Author: bjorn3

.gitignore

@@ -1,2 +1,3 @@
-target
-Cargo.lock
+/target
+/Cargo.lock
+/.vscode

Cargo.toml

@@ -12,3 +12,8 @@ repository = "https://github.com/rust-lang/ar_archive_writer"
 
 [dependencies]
 object = { version = "0.32.0", default-features = false, features = ["std", "read"] }
+
+[dev-dependencies]
+cargo-binutils = "0.3.6"
+object = { version = "0.32.0", default-features = false, features = ["write", "xcoff"] }
+pretty_assertions = "1.4.0"

rust-toolchain.toml

@@ -0,0 +1,3 @@
+[toolchain]
+channel = "stable"
+components = ["llvm-tools"]

src/archive_writer.rs

@@ -497,9 +497,7 @@ fn compute_member_data<'a, S: Write + Seek>(
             *filename_count.entry(&*m.member_name).or_insert(0) += 1;
         }
         for (_name, count) in filename_count.iter_mut() {
-            if *count > 1 {
-                *count = 1;
-            }
+            *count = if *count > 1 { 1 } else { 0 };
         }
     }