Skip to content

Commit 75419c7

Browse files
committed
Minor updates
1 parent ea38a04 commit 75419c7

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

library/std/build.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -133,16 +133,17 @@ fn main() {
133133
_ => false,
134134
};
135135

136+
// These are currently empty, but will fill up as some platforms move from completely
137+
// unreliable to reliable basics but unreliable math.
138+
136139
// LLVM is currenlty adding missing routines, <https://github.com/llvm/llvm-project/issues/93566>
137140
let has_reliable_f16_math = has_reliable_f16
138141
&& match (target_arch.as_str(), target_os.as_str()) {
139-
("x86", _) => false,
140142
_ => true,
141143
};
142144

143145
let has_reliable_f128_math = has_reliable_f128
144146
&& match (target_arch.as_str(), target_os.as_str()) {
145-
// ("aarch64", _) => false,
146147
_ => true,
147148
};
148149

library/std/src/f16/tests.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -423,13 +423,11 @@ fn test_recip() {
423423

424424
#[test]
425425
fn test_powi() {
426-
// FIXME(f16_f128): LLVM misoptimizes `powi.f16`
426+
// FIXME(llvm19): LLVM misoptimizes `powi.f16`
427427
// <https://github.com/llvm/llvm-project/issues/98665>
428428
// let nan: f16 = f16::NAN;
429429
// let inf: f16 = f16::INFINITY;
430430
// let neg_inf: f16 = f16::NEG_INFINITY;
431-
// dbg!(1.0f16);
432-
// dbg!(1.0f16.powi(1));
433431
// assert_eq!(1.0f16.powi(1), 1.0);
434432
// assert_approx_eq!((-3.1f16).powi(2), 9.61, TOL_0);
435433
// assert_approx_eq!(5.9f16.powi(-2), 0.028727, TOL_N2);

0 commit comments

Comments
 (0)