Add base_isa
setting for RISC-V
#941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
riscv-rt
macros use environment variables to capture characteristics of the target (e.g., RV64 vs RV32, vector table alignment...). Whileriscv-rt
properly sets a few environment variables in itsbuild.rs
script for its internals, these environment variables do not outlive the compilation of other crates (e.g., PACs). Thus, PACs, as users ofriscv-rt
macros, must also define theRISCV_RT_BASE_ISA
environment variable to make sure that the generated code supports vectored mode.This PR includes this field in the
settings.yaml
file. As ignoring this field may lead to programs hanging, I also included warning messages to recommend that PAC maintainers include this field if their target supports vectored mode.