Skip to content

Improve internals to allow having much smaller HTML generated #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve internals to allow having much smaller HTML generated #262

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
429664a
Add new `use_html5` API in `Term`
GuillaumeGomez Jul 28, 2025
348b6c6
Create new `SpanKind` type to be used in `write_bg_span` and `write_f…
GuillaumeGomez Jul 28, 2025
797e225
Add new `write_classes` utility function
GuillaumeGomez Jul 28, 2025
839ef19
Don't create a tag element if there is no style to apply
GuillaumeGomez Jul 29, 2025
6ba4c30
Split rendering of `SpanKind::Tspan` and `SpanKind::Span`
GuillaumeGomez Jul 29, 2025
87825e6
Remove `<span>` tag wrapping if it contains a link (`<a>`)
GuillaumeGomez Jul 29, 2025
d0462a3
Remove some unneeded extra backlines and indent
GuillaumeGomez Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions crates/anstyle-svg/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,24 +504,42 @@ fn write_fg_span(buffer: &mut String, span: SpanKind, element: &adapter::Element
classes.push("hidden");
}

if span != SpanKind::Tspan && classes.is_empty() && element.url.is_none() {
// No need to create an element if there is no class or href.
write!(buffer, "{fragment}").unwrap();
}
let mut need_closing_a = false;
Copy link
Collaborator

@epage epage Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If already splitting everything, why not have this in the match?


write!(buffer, r#"<{span}"#).unwrap();
write_classes(buffer, classes);
write!(buffer, r#">"#).unwrap();
if let Some(hyperlink) = &element.url {
write!(buffer, r#"<a href="{hyperlink}">"#).unwrap();
need_closing_a = true;
}
write!(buffer, "{fragment}").unwrap();
if need_closing_a {
write!(buffer, r#"</a>"#).unwrap();
match span {
SpanKind::Span => {
if classes.is_empty() && element.url.is_none() {
// No need to create an element if there is no class or href.
write!(buffer, "{fragment}").unwrap();
}
write!(buffer, r#"<span"#).unwrap();
write_classes(buffer, classes);
write!(buffer, r#">"#).unwrap();
if let Some(hyperlink) = &element.url {
write!(buffer, r#"<a href="{hyperlink}">"#).unwrap();
need_closing_a = true;
}
write!(buffer, "{fragment}").unwrap();
if need_closing_a {
write!(buffer, r#"</a>"#).unwrap();
}
write!(buffer, r#"</span>"#).unwrap();
}
SpanKind::Tspan => {
write!(buffer, r#"<tspan"#).unwrap();
write_classes(buffer, classes);
write!(buffer, r#">"#).unwrap();
if let Some(hyperlink) = &element.url {
write!(buffer, r#"<a href="{hyperlink}">"#).unwrap();
need_closing_a = true;
}
write!(buffer, "{fragment}").unwrap();
if need_closing_a {
write!(buffer, r#"</a>"#).unwrap();
}
write!(buffer, r#"</tspan>"#).unwrap();
}
}
write!(buffer, r#"</{span}>"#).unwrap();
}

fn write_bg_span(buffer: &mut String, span: SpanKind, style: &anstyle::Style, fragment: &str) {
Expand Down