Skip to content

Commit e6643c0

Browse files
committed
CI: Pin dependencies for MSRV build ... properly
Commit `0e0dcb7f CI: Pin dependencies required for MSRV build` is totally wrong, why did it get through CI? In the CI script do: - `serde_json` is not a dependency of `secp256k1`, remove the pinning - Put the pinning _before_ any call to `cargo` - Pin the transient dependency `wasm-bindgen-test`
1 parent 8e48e15 commit e6643c0

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

contrib/test.sh

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,18 @@ if cargo --version | grep nightly; then
1313
NIGHTLY=true
1414
fi
1515

16+
# Pin dependencies as required if we are using MSRV toolchain.
17+
if cargo --version | grep "1\.48"; then
18+
cargo update -p wasm-bindgen-test --precise 0.3.34
19+
cargo update -p serde --precise 1.0.156
20+
fi
21+
1622
# Test if panic in C code aborts the process (either with a real panic or with SIGILL)
1723
cargo test -- --ignored --exact 'tests::test_panic_raw_ctx_should_terminate_abnormally' 2>&1 | tee /dev/stderr | grep "SIGILL\\|panicked at '\[libsecp256k1\]"
1824

1925
# Make all cargo invocations verbose
2026
export CARGO_TERM_VERBOSE=true
2127

22-
# Pin dependencies as required if we are using MSRV toolchain.
23-
if cargo --version | grep "1\.48"; then
24-
# 1.0.157 uses syn 2.0 which requires edition 2021
25-
cargo update -p serde_json --precise 1.0.99
26-
cargo update -p serde --precise 1.0.156
27-
fi
28-
2928
# Defaults / sanity checks
3029
cargo build --all
3130
cargo test --all

0 commit comments

Comments
 (0)