`verify` and `integration_test` are not linted in CI

[tcharding]

Both these crates have a bunch of clippy warnings, it would be nice to clear them then enforce it in CI. They are skipped right now because they are excluded from the workspace.

[0xZaddyy]

Hi Sir, i'm already working on this.

[0xZaddyy]

sir, i'm able to clear most clippy warnings but currently i'm stuck.
working on integration_test there is a compilation error related to the generate method in corepc_node::Client: when i run just lint

error[E0599]: no method named `generate` found for struct `corepc_node::Client` in the current scope
  --> integration_test/tests/generating.rs:18:38
   |
18 |     let json: Generate = node.client.generate(NBLOCKS).expect("generate");
   |                                      ^^^^^^^^ method not found in `Client`

I see there's already a #[cfg(feature = "v17")] guarding the test. However, the method still seems unavailable in the current Client implementation, which causes the test to fail at compile time.

Should we:

• Add the generate method back behind a feature flag in corepc_node::Client for legacy support?

• Remove the test entirely since newer Core versions no longer support it?

• Refactor the test to rely solely on generate_to_address, which is still valid?

[tcharding]

The problem is with how features work in integration_test. I wrote a script to run the linter for you, see #258 . Using that should get you started.

You'll probably want to modify the script to use it with verify also once you are done with the integration test crate. Could be a separate PR.

After both lint cleanly we can enforce it in CI

[0xZaddyy]

oh now i understand, Thank you sir.

[jamillambert]

oh now i understand, Thank you sir.

@0xZaddyy Sorry I think I just submitted a PR that does what you are working on. I just saw #258 and did it before looking here.

I only did integration_tests though, you could work on verify.

[0xZaddyy]

Alright ser!
Thank you @jamillambert