Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate schedule selection based on foundry.toml, kontrol.toml and defaults #934

Open
palinatolmach opened this issue Jan 17, 2025 · 0 comments

Comments

@palinatolmach
Copy link
Collaborator

Related: #800

  1. At the moment, the default schedule is Shanghai, however, there're many projects using newer Solidity versions that cause an undefined instruction error in kontrol prove. Previously, we have postponed making Cancun the default schedule, however, we can do it now since we've implemented most of the EIPs; Cancun is also the default evm_version in Foundry.
  2. To make the default schedule more obvious to users, we should also add the schedule = 'CANCUN' entry to the kontrol.toml file that gets generated by kontrol init.
  3. Another way to set schedule/evm version is by providing the evm_version = 'cancun' field in foundry.toml. We should probably recognize that as well and decide on the priority between Kontrol's --schedule and foundry.toml's, evm_version (I'd suggest schedule > evm_version).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant