Add allowCalls cheatcode
#926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvacaru
reviewed
Jan 16, 2025
Co-authored-by: Andrei Văcaru <[email protected]>
palinatolmach
force-pushed
the
allow-calls-cheatcode
branch
from
3d633d3 to
7a09749
Compare
anvacaru
reviewed
Jan 17, 2025
Co-authored-by: Andrei Văcaru <[email protected]>
|
Cheatcode seems to be working on our test. Lisandra is just running some further checks but I think we should be fine to get this merged once we get around the CI issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: runtimeverification/kontrol-cheatcodes#19.Closes #923.
This PR introduces a new cheatcode
allowCalls(address, bytes calldata)that allows whitelisting calls to a specific address with specific calldata. The PR:<addressList>cell to<allowedCallsList>in<whitelist>CallToAddressproduction to facilitate representing whitelisted{ address | calldata }pairsallowCallsToAddress(address)so it adds the following element to the list,*representing any possible calldata:ListItem({ALLOWEDACCOUNT|b"*"})foundry.catchNonWhitelistedCallsrule so it gets applied before a call if the whitelist has been enable (it did not previously)allowCallscheatcodeallowCallsand enablesauxiliary-lemmasinend-to-endtestsallowCallsToAddress(address)so they only check whetherallowCallsToAddressis workingend-to-endtests from 8 to 6, since it frequently fails with OOM (we had to make a similar change in integration tests earlier)In addition, this PR adds the simplifications required for checking
Listmembership to the auxiliary Kontrol lemmas file. These lemmas are to be upstreamed to the K repo.TODO: update expected output