Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting integration tests between several folders #458

Open
palinatolmach opened this issue Mar 15, 2024 · 1 comment
Open

Consider splitting integration tests between several folders #458

palinatolmach opened this issue Mar 15, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@palinatolmach
Copy link
Collaborator

palinatolmach commented Mar 15, 2024

As @anvacaru suggested, in KEVM, tests are split between several proof folders depending on the project, where each project can have a separate lemma file.

In Kontrol, there's a single Foundry project under tests/integration, while it might make sense to move, e.g., the Optimism test with a dedicate set of lemmas (will be added in #369) or CSE tests to their own folders. That would likely ensure that lemmas are only applied in relevant contracts while #442 is being investigated. In addition, it would make individual definitions more compact than the current common one, which might be easier to inspect.

At the same time, this should also be coordinated with the Haskell Backend team who use our tests for profiling.

@yale-vinson
Copy link

@palinatolmach & @anvacaru Once you guys discuss this issue in the Monday Standup, I would move it to "Next Up", unless someone wants to jump right on it and move it to "In Progress".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants