Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting branch handling in pyk #4186

Open
PetarMax opened this issue Apr 9, 2024 · 0 comments
Open

Revisiting branch handling in pyk #4186

PetarMax opened this issue Apr 9, 2024 · 0 comments

Comments

@PetarMax
Copy link
Contributor

PetarMax commented Apr 9, 2024

With the merging of runtimeverification/pyk#942, the branching responses from the backend now come with rule identifiers and branching conditions. This information should allow us to minimize the use of the heuristic branch extraction and branching patterns and simply rely on the provided information instead.

A draft PR runtimeverification/pyk#1072 has been opened showing promising results. I would like to use this issue to discuss options with @ehildenb, @tothtamas28, @jberthold, @goodlyrottenapple, @geo2a, and others. In particular, I would like to understand:

  1. How would it be possible for a branching to happen and the rule_predicate field not to have some sort of branching condition (i.e., equal None)? Would that be a pure non-deterministic transition and if so, would the rule_predicate effectively be #Top? Are there other possibilities?
  2. Does the rule_id field of each next state in a branching response have the identifier of the rule that was used to create that branch? Is it possible for this field to be None?
  3. Do we actually care if there is branch overlapping/non-determinism happening if we have got all the branching conditions right?
@PetarMax PetarMax linked a pull request Apr 9, 2024 that will close this issue
@PetarMax PetarMax changed the title Revisiting how branching is handled Revisiting branch handling in pyk Apr 9, 2024
@PetarMax PetarMax changed the title Revisiting branch handling in pyk Revisiting branch handling in pyk Apr 9, 2024
@Baltoli Baltoli added the pyk label Apr 10, 2024
@Baltoli Baltoli transferred this issue from runtimeverification/pyk Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants