Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop clone + run of tutorial tests #3962

Closed
Baltoli opened this issue Feb 6, 2024 · 0 comments
Closed

Drop clone + run of tutorial tests #3962

Baltoli opened this issue Feb 6, 2024 · 0 comments

Comments

@Baltoli
Copy link
Contributor

Baltoli commented Feb 6, 2024

In #3901, we dropped the PL tutorial as a separate step when running tests in CI, and instead opted to upstream a selection of the supported definitions into the K regression test suite.

In #3956, the change to prohibit rather than deprecate macro-like attributes on non-production sentences broke CI because it's still trying to run the full set of PL tutorial tests via the cloned repository.

We should:

  • Drop this explicit testing step from the K CI; doing so was the point of moving the tests into the regression test suite in the first place.
  • Modernise the PL tutorial definitions and set up CI on that repository: Set up CI pl-tutorial#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant