feat: support npm:postgres

[himself65]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: f62336c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
llama-index-ts-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 1:43am

[himself65]

forward to some our previous contributors see if like/dislike this change

/cc @gorango @AndreMaz

[himself65]

I think in the future, there could have sqlite vector store, so type should also comptatable with node:sqlite sqlite3 better-sqlite3

[himself65]

#1184

[pkg-pr-new]

Open in Stackblitz

@llamaindex/autotool

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/autotool@1248

@llamaindex/cloud

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/cloud@1248

@llamaindex/community

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/community@1248

@llamaindex/core

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/core@1248

@llamaindex/env

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/env@1248

llamaindex

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/llamaindex@1248

@llamaindex/experimental

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/experimental@1248

@llamaindex/wasm-tools

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/wasm-tools@1248

commit: f62336c

[AndreMaz]

This is just personal preference but I would do things in a slightly different way.

Instead of function fromPostgres() and function fromPG() I would create a dir called adapters at src/vector-store and then create a base.ts adapter with the connect(), disconnect(), query() and etc. methods.

Then I would create the pg.ts that would extend the base.ts and implement the logic in there. Same for the postgres and other clients.

After this the PGVectorStore would have a reference to the adapter instance and then call it as needed.

I would also export the base.ts to allow the user to create their own version of adapter (node:sqlite, sqlite3, better-sqlite3 or any other) and pass it as a param to a PGVectorStore's constructor(). Essentially the user would be allowed to pass a custom adapter to the vector-store (as long as it correctly implements the methods of base.ts)

@himself65 what I said above is just a suggestion that I think will be easier to maintain in the long run. Other than that your PR looks good 👍