🚧 [DO NOT MERGE] Un-pend Data tests for JRuby/TruffleRuby

This should _not_ be merged into main.  😉

It's only temporary, to track bugs in TruffleRuby and JRuby until they
are addressed.

Author: nevans

test/net/imap/test_connection_state.rb

@@ -25,25 +25,23 @@ class ConnectionStateTest < Net::IMAP::TestCase
   end
 
   test "#deconstruct" do
-    pend_if_truffleruby "TruffleRuby bug overriding ::Data methods" do
-      assert_equal [:not_authenticated], NotAuthenticated[].deconstruct
-      assert_equal [:authenticated],     Authenticated[]   .deconstruct
-      assert_equal [:selected],          Selected[]        .deconstruct
-      assert_equal [:logout],            Logout[]          .deconstruct
-    end
+    # TODO: TruffleRuby's Data fails these
+    assert_equal [:not_authenticated], NotAuthenticated[].deconstruct
+    assert_equal [:authenticated],     Authenticated[]   .deconstruct
+    assert_equal [:selected],          Selected[]        .deconstruct
+    assert_equal [:logout],            Logout[]          .deconstruct
   end
 
   test "#deconstruct_keys" do
-    pend_if_truffleruby "TruffleRuby bug overriding ::Data methods" do
-      assert_equal({symbol: :not_authenticated}, NotAuthenticated[].deconstruct_keys([:symbol]))
-      assert_equal({symbol: :authenticated},     Authenticated[]   .deconstruct_keys([:symbol]))
-      assert_equal({symbol: :selected},          Selected[]        .deconstruct_keys([:symbol]))
-      assert_equal({symbol: :logout},            Logout[]          .deconstruct_keys([:symbol]))
-      assert_equal({name: "not_authenticated"},  NotAuthenticated[].deconstruct_keys([:name]))
-      assert_equal({name: "authenticated"},      Authenticated[]   .deconstruct_keys([:name]))
-      assert_equal({name: "selected"},           Selected[]        .deconstruct_keys([:name]))
-      assert_equal({name: "logout"},             Logout[]          .deconstruct_keys([:name]))
-    end
+    # TODO: TruffleRuby's Data fails these
+    assert_equal({symbol: :not_authenticated}, NotAuthenticated[].deconstruct_keys([:symbol]))
+    assert_equal({symbol: :authenticated},     Authenticated[]   .deconstruct_keys([:symbol]))
+    assert_equal({symbol: :selected},          Selected[]        .deconstruct_keys([:symbol]))
+    assert_equal({symbol: :logout},            Logout[]          .deconstruct_keys([:symbol]))
+    assert_equal({name: "not_authenticated"},  NotAuthenticated[].deconstruct_keys([:name]))
+    assert_equal({name: "authenticated"},      Authenticated[]   .deconstruct_keys([:name]))
+    assert_equal({name: "selected"},           Selected[]        .deconstruct_keys([:name]))
+    assert_equal({name: "logout"},             Logout[]          .deconstruct_keys([:name]))
   end
 
   test "#not_authenticated?" do

test/net/imap/test_data_lite.rb

@@ -154,6 +154,7 @@ def test_inspect
       end
 
       def test_recursive_inspect
+        # TODO: TruffleRuby's Data fails this test with a StackOverflowError
         klass = Data.define(:value, :head, :tail) do
           def initialize(value:, head: nil, tail: nil)
             case tail
@@ -174,32 +175,32 @@ def initialize(value:, head: nil, tail: nil)
           end
         end
 
-        pend_if_jruby do
-          # anonymous class
-          list = klass[value: 1, tail: [2, 3, 4]]
-          seen = "#<data #{klass.inspect}:...>"
-          assert_equal(
-            "#<data value=1, head=nil," \
-            " tail=#<data value=2, head=#{seen}," \
-            " tail=#<data value=3, head=#{seen}," \
-            " tail=#<data value=4, head=#{seen}," \
-            " tail=nil>>>>",
-            list.inspect
-          )
-
-          # named class
-          Object.const_set(:DoubleLinkList, klass)
-          list = DoubleLinkList[value: 1, tail: [2, 3, 4]]
-          seen = "#<data DoubleLinkList:...>"
-          assert_equal(
-            "#<data DoubleLinkList value=1, head=nil," \
-            " tail=#<data DoubleLinkList value=2, head=#{seen}," \
-            " tail=#<data DoubleLinkList value=3, head=#{seen}," \
-            " tail=#<data DoubleLinkList value=4, head=#{seen}," \
-            " tail=nil>>>>",
-            list.inspect
-          )
-        end
+        # anonymous class
+        list = klass[value: 1, tail: [2, 3, 4]]
+        seen = "#<data #{klass.inspect}:...>"
+        assert_equal(
+          "#<data value=1, head=nil," \
+          " tail=#<data value=2, head=#{seen}," \
+          " tail=#<data value=3, head=#{seen}," \
+          " tail=#<data value=4, head=#{seen}," \
+          " tail=nil>>>>",
+          # TODO: JRuby's Data fails on the next line
+          list.inspect
+        )
+
+        # named class
+        Object.const_set(:DoubleLinkList, klass)
+        list = DoubleLinkList[value: 1, tail: [2, 3, 4]]
+        seen = "#<data DoubleLinkList:...>"
+        assert_equal(
+          "#<data DoubleLinkList value=1, head=nil," \
+          " tail=#<data DoubleLinkList value=2, head=#{seen}," \
+          " tail=#<data DoubleLinkList value=3, head=#{seen}," \
+          " tail=#<data DoubleLinkList value=4, head=#{seen}," \
+          " tail=nil>>>>",
+          # TODO: JRuby's Data fails on the next line
+          list.inspect
+        )
       ensure
         Object.instance_eval { remove_const(:DoubleLinkList) } rescue nil
       end
@@ -350,6 +351,7 @@ class Inherited < Abstract.define(:foo)
       end
 
       def test_subclass_can_create
+        # TODO: JRuby's Data fails all of these
         assert_equal 1, Inherited[1]    .foo
         assert_equal 2, Inherited[foo: 2].foo
         assert_equal 3, Inherited.new(3).foo
@@ -364,9 +366,8 @@ class InheritsClassMethod < AbstractWithClassMethod.define(:foo)
       end
 
       def test_subclass_class_method
-        pend_if_jruby do
-          assert_equal :ok, InheritsClassMethod.inherited_class_method
-        end
+        # TODO: JRuby's Data fails on the next line
+        assert_equal :ok, InheritsClassMethod.inherited_class_method
       end
 
       class AbstractWithOverride < Data
@@ -377,10 +378,10 @@ class InheritsOverride < AbstractWithOverride.define(:foo)
       end
 
       def test_subclass_override_deconstruct
+        # TODO: JRuby's Data fails on the next line
         data = InheritsOverride[:foo]
-        pend_if_truffleruby do
-          assert_equal %i[ok foo], data.deconstruct
-        end
+        # TODO: TruffleRuby's Data fails on the next line
+        assert_equal %i[ok foo], data.deconstruct
       end
 
     end

test/net/imap/test_vanished_data.rb

@@ -54,13 +54,11 @@ class VanishedDataTest < Net::IMAP::TestCase
   end
 
   test ".[], mixing args raises ArgumentError" do
-    pend_if_jruby do
-      assert_raise ArgumentError do
-        VanishedData[1, true, uids: "1", earlier: true]
-      end
-      assert_raise ArgumentError do VanishedData["1234", earlier: true] end
-      assert_raise ArgumentError do VanishedData[nil, true, uids: "1"]  end
+    assert_raise ArgumentError do
+      VanishedData[1, true, uids: "1", earlier: true]
     end
+    assert_raise ArgumentError do VanishedData["1234", earlier: true] end
+    assert_raise ArgumentError do VanishedData[nil, true, uids: "1"]  end
   end
 
   test ".[], missing args raises ArgumentError" do