Debug test configuration - #134
Merged
rubberduck-dev01 merged 3 commits intoAug 19, 2026
Merged
Conversation
The solution excluded RDCore.Tests from Debug builds, so the default 'dotnet test RDCore.slnx' invocation reported success without discovering any tests. Removes the exclusion, adds Debug legs to CI alongside the existing Release legs, and documents the canonical build and test commands in CONTRIBUTING.md (both languages).
Member
|
Mind resynchronizing? I missed the PR and pushed a small diff on CONTRIBUTING.md to relax the "no agents" bit... and that's the conflict, of course 😅 |
rubberduck-dev01
previously approved these changes
Aug 19, 2026
Signed-off-by: Rubberduck VBA Admin <admin@rubberduckvba.ca>
rubberduck-dev01
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
RDCore.slnxexcludedRDCore.TestsfromDebug|*, and Debug is the default configuration fordotnet. So the documented-by-habit invocation reported success having discovered nothing, anddotnet build RDCore.slnxcouldn't catch a compile break in the test project either.Before, on
main:After:
Release is unaffected: 852/852, verified separately.
Changes
RDCore.slnx— removed<Build Solution="Debug|*" Project="false" />from theRDCore.Testsentry..github/workflows/build.yml— added Debug build and test steps ahead of the existing Release ones. I kept these as steps inside the singlebuild-and-testjob rather than converting to a matrix, so the check name doesn't change; happy to switch to a matrix if you'd rather.CONTRIBUTING.md— a "Building and testing" / "Bâtir et tester" section in both halves, naming .NET 10 and the canonical commands, with a note that a run discovering no tests is not a passing run.One thing worth knowing before you read the diff
CONTRIBUTING.mdis the only one of the 696 tracked files stored with CRLF in the index (git ls-files --eol), so any edit to it renormalises the entire file under the existingtext=autoattribute. I've isolated that into its own commit so the content change stays reviewable — the second commit is the one with the actual edit; the first is 89 lines of pure line-ending change and nothing else.