Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combineWidgets loses class of widgets #49

Closed
dmurdoch opened this issue Jan 24, 2018 · 1 comment
Closed

combineWidgets loses class of widgets #49

dmurdoch opened this issue Jan 24, 2018 · 1 comment

Comments

@dmurdoch
Copy link
Contributor

htmlwidgets creates a class for the div holding a widget that contains the name of the widget, and some other stuff. combineWidgets just uses class cw-widget, ignoring the original class.

This causes trouble for rgl, because it provides some style info in a CSS file that depends on the class attribute for the div.

I have a patch on dmurdoch/manipulateWidget in the keepclass branch, but it also includes the previous patch. I don't know how to submit a PR that only includes the new stuff.

@bthieurmel
Copy link
Collaborator

Thanks. Merge your PR in next_release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants