-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update package.json for publishing #4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
166a66f
Update package.json for publishing
wch e919536
Use custom readme file for npm
wch c59fbe5
Update repository URLs
wch 734fc86
Script cleanup
wch e513071
Use name @posit/shiny
wch 3d351d3
Merge branch 'main' into publish-npm
wch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| @posit/shiny | ||
| ============ | ||
|
|
||
| This npm package contains TypeScript type definitions for Shiny's client-side JavaScript libraries. | ||
|
|
||
| It does not include the Shiny framework itself, though that may change in the future. | ||
|
|
||
| [Shiny](https://github.com/rstudio/shiny) is a web application framework for both R and Python, developed by Posit PBC. | ||
|
|
||
| ## Installation | ||
|
|
||
| ```bash | ||
| npm install @posit/shiny | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: It looks like
yarn packdoes not ignore README-orig.md (so it gets included in the package), butnpm packdoes ignore the file, which is the behavior that we want.From what I can find, it's going to require awkward stuff to make
yarn packignore that file, like moving the temporary file to /tmp. Since we're planning on switching tonpmanyway, I suggest we just leave this as it is. We can publish it withnpm publishjust fine, even if we're using yarn for other steps.