-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update package.json for publishing #4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've updated it so that:
The current build system puts the .d.ts files into In the future, I think we'll want to publish the JS and types together in a single package. To do that, I think we should:
|
| "coverage": "type-coverage -p tsconfig.json --at-least 90", | ||
| "circular": "npx --yes dpdm --transform ./srcts/src/index.ts" | ||
| "circular": "npx --yes dpdm --transform ./srcts/src/index.ts", | ||
| "prepack": "cp README.md README-orig.md && cp npm-README.md README.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: It looks like yarn pack does not ignore README-orig.md (so it gets included in the package), but npm pack does ignore the file, which is the behavior that we want.
From what I can find, it's going to require awkward stuff to make yarn pack ignore that file, like moving the temporary file to /tmp. Since we're planning on switching to npm anyway, I suggest we just leave this as it is. We can publish it with npm publish just fine, even if we're using yarn for other steps.
This PR updates package.json for publishing to npmjs.com.