From 3e8ba5ff563aa527108126496dd2bcfb93b467aa Mon Sep 17 00:00:00 2001 From: "Joshua C. Forest" Date: Thu, 14 Nov 2024 13:23:12 -0500 Subject: [PATCH 1/4] Include some basic tests to verify the serverAccount name is being set as we expect --- .../tests/service_accounts_test.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 charts/rstudio-workbench/tests/service_accounts_test.yaml diff --git a/charts/rstudio-workbench/tests/service_accounts_test.yaml b/charts/rstudio-workbench/tests/service_accounts_test.yaml new file mode 100644 index 00000000..87dc62ef --- /dev/null +++ b/charts/rstudio-workbench/tests/service_accounts_test.yaml @@ -0,0 +1,54 @@ +suite: Workbench Service Accounts +templates: + - configmap-general.yaml + - configmap-prestart.yaml + - configmap-secret.yaml + - configmap-session.yaml + - deployment.yaml +tests: + - it: should set the Workbench pod service account when the launcher is enabled + template: deployment.yaml + set: + launcher: + enabled: true + rbac: + serviceAccount: + name: "workbench-service-account" + asserts: + - equal: + path: "spec.template.spec.serviceAccountName" + value: "workbench-service-account" + - it: should set the Workbench pod service account when the launcher is not enabled + template: deployment.yaml + set: + launcher: + enabled: false + rbac: + serviceAccount: + name: "workbench-service-account" + asserts: + - equal: + path: "spec.template.spec.serviceAccountName" + value: "workbench-service-account" + - it: should use the default serviceAccount name when not set + template: deployment.yaml + asserts: + - equal: + path: "spec.template.spec.serviceAccountName" + value: "RELEASE-NAME-rstudio-workbench" + - it: should use the nameOverride as part of the serviceAccount name when nameOverride is set + template: deployment.yaml + set: + nameOverride: "posit-workbench" + asserts: + - equal: + path: "spec.template.spec.serviceAccountName" + value: "RELEASE-NAME-posit-workbench" + - it: should use the fullnameOverride as the serviceAccount name when fullnameOverride is set + template: deployment.yaml + set: + fullnameOverride: "posit-workbench" + asserts: + - equal: + path: "spec.template.spec.serviceAccountName" + value: "posit-workbench" From 5106a4e8b63ca3ce50f1858607a2590d35da93d2 Mon Sep 17 00:00:00 2001 From: "Joshua C. Forest" Date: Thu, 14 Nov 2024 13:36:02 -0500 Subject: [PATCH 2/4] ignore the files in the tests dir as well --- charts/rstudio-workbench/.helmignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/rstudio-workbench/.helmignore b/charts/rstudio-workbench/.helmignore index 1cbd52de..6b559e16 100644 --- a/charts/rstudio-workbench/.helmignore +++ b/charts/rstudio-workbench/.helmignore @@ -3,4 +3,4 @@ Makefile *.gotmpl # chart tests -tests/ +tests/* From 1967b38beba1474a124eb4b96277d1884b2227c8 Mon Sep 17 00:00:00 2001 From: "Joshua C. Forest" Date: Thu, 14 Nov 2024 13:37:18 -0500 Subject: [PATCH 3/4] I guess I need to bump the chart version for this --- charts/rstudio-workbench/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/rstudio-workbench/Chart.yaml b/charts/rstudio-workbench/Chart.yaml index 46d386ef..c66cd382 100644 --- a/charts/rstudio-workbench/Chart.yaml +++ b/charts/rstudio-workbench/Chart.yaml @@ -1,6 +1,6 @@ name: rstudio-workbench description: Official Helm chart for Posit Workbench -version: 0.8.7 +version: 0.8.8 apiVersion: v2 appVersion: 2024.09.1 icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png From 702bcc4546d4974ab5763c55d8fde1c3e880bce4 Mon Sep 17 00:00:00 2001 From: GitHub Actions Date: Thu, 14 Nov 2024 18:38:17 +0000 Subject: [PATCH 4/4] Update helm-docs and README.md --- charts/rstudio-workbench/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/rstudio-workbench/README.md b/charts/rstudio-workbench/README.md index f79e701d..4cbf7f3e 100644 --- a/charts/rstudio-workbench/README.md +++ b/charts/rstudio-workbench/README.md @@ -1,6 +1,6 @@ # Posit Workbench -![Version: 0.8.7](https://img.shields.io/badge/Version-0.8.7-informational?style=flat-square) ![AppVersion: 2024.09.1](https://img.shields.io/badge/AppVersion-2024.09.1-informational?style=flat-square) +![Version: 0.8.8](https://img.shields.io/badge/Version-0.8.8-informational?style=flat-square) ![AppVersion: 2024.09.1](https://img.shields.io/badge/AppVersion-2024.09.1-informational?style=flat-square) #### _Official Helm chart for Posit Workbench_ @@ -24,11 +24,11 @@ To ensure a stable production deployment: ## Installing the chart -To install the chart with the release name `my-release` at version 0.8.7: +To install the chart with the release name `my-release` at version 0.8.8: ```{.bash} helm repo add rstudio https://helm.rstudio.com -helm upgrade --install my-release rstudio/rstudio-workbench --version=0.8.7 +helm upgrade --install my-release rstudio/rstudio-workbench --version=0.8.8 ``` To explore other chart versions, look at: