-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having a delegate can lead to black video output #63
Comments
I believe it's because the delegate uses a |
@joshbax i tried your suggestion, it doesn't fix the issue |
We are experiencing this as well. Happens about every 6-8 videos. Any other suggestions? |
A bit more info, it's actually not an intermittent problem as I previously thought. For us, the front camera works fine, but the back camera always renders black. If you look closely, our videos have a 1 pixel vertical line in which you see part of the video playing while the rest is black. Audio works fine. We tried @joshbax suggestion, and also tried changes made in this PR: https://github.com/rs/SDAVAssetExportSession/pull/58/files#diff-31ccfacb15a054f36d2e5b7b1d4ec6d2R137 Unfortunately, nothing worked and we haven't found a solution yet. |
I personally ended up changing the delegate to just be |
I don't understand the reason well, but setting a delegate can lead to the result being black. I've noticed that having a delegate leads to extra things being run: https://github.com/rs/SDAVAssetExportSession/blob/master/SDAVAssetExportSession.m#L243-L254
so that's probably creating the issue, even though I'm not sure how
The text was updated successfully, but these errors were encountered: