Skip to content

Commit 174e9ce

Browse files
drm/xe/guc: Drop error messages about missing GuC logs
The GuC log snapshot code would complain loudly if there was no GuC log to take a snapshot of or if the snapshot alloc failed. Originally, this code was only called on demand when a user (or developer) explicitly requested a dump of the log. Hence an error message was useful. However, it is now part of the general devcoredump file and is called for any GPU hang. Most people don't care about GuC logs and GPU hangs do not generally mean a kernel/GuC bug. More importantly, there are valid situations where there is no GuC log, e.g. SRIOV VFs. So drop the error message. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3958 Signed-off-by: John Harrison <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 11a64ad commit 174e9ce

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/gpu/drm/xe/xe_guc_log.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,16 +149,12 @@ struct xe_guc_log_snapshot *xe_guc_log_snapshot_capture(struct xe_guc_log *log,
149149
size_t remain;
150150
int i;
151151

152-
if (!log->bo) {
153-
xe_gt_err(gt, "GuC log buffer not allocated\n");
152+
if (!log->bo)
154153
return NULL;
155-
}
156154

157155
snapshot = xe_guc_log_snapshot_alloc(log, atomic);
158-
if (!snapshot) {
159-
xe_gt_err(gt, "GuC log snapshot not allocated\n");
156+
if (!snapshot)
160157
return NULL;
161-
}
162158

163159
remain = snapshot->size;
164160
for (i = 0; i < snapshot->num_chunks; i++) {

0 commit comments

Comments
 (0)