dnf5: Print details about concurrent running transaction

Author: m-blaha

dnf5/context.cpp

@@ -42,6 +42,7 @@
 #include <libdnf5/utils/fs/file.hpp>
 #include <libdnf5/utils/patterns.hpp>
 #include <rpm/rpmtypes.h>
+#include <signal.h>
 
 #include <algorithm>
 #include <cctype>
@@ -58,6 +59,48 @@ namespace dnf5 {
 
 namespace {
 
+// Helper function to format active transaction information for error messages
+std::string format_active_transaction_info(const libdnf5::base::ActiveTransactionInfo & info) {
+    std::string result;
+
+    if (!info.get_description().empty()) {
+        result += libdnf5::utils::sformat(_("Command: {}"), info.get_description());
+    }
+
+    if (info.get_pid() > 0) {
+        if (!result.empty()) {
+            result += "\n";
+        }
+        if (kill(info.get_pid(), 0) == 0) {
+            result += libdnf5::utils::sformat(_("Process ID: {} (still running)"), info.get_pid());
+        } else {
+            result += libdnf5::utils::sformat(_("Process ID: {}"), info.get_pid());
+        }
+    }
+
+    if (info.get_start_time() > 0) {
+        if (!result.empty()) {
+            result += "\n";
+        }
+        auto start_time = static_cast<time_t>(info.get_start_time());
+        auto time_str = std::string(std::ctime(&start_time));
+        // Remove trailing newline from ctime
+        if (!time_str.empty() && time_str.back() == '\n') {
+            time_str.pop_back();
+        }
+        result += libdnf5::utils::sformat(_("Started: {}"), time_str);
+    }
+
+    if (!info.get_comment().empty()) {
+        if (!result.empty()) {
+            result += "\n";
+        }
+        result += libdnf5::utils::sformat(_("Comment: {}"), info.get_comment());
+    }
+
+    return result;
+}
+
 // The `KeyImportRepoCB` class implements callback only for importing repository key.
 class KeyImportRepoCB : public libdnf5::repo::RepoCallbacks2_1 {
 public:
@@ -377,6 +420,24 @@ void Context::Impl::store_offline(libdnf5::base::Transaction & transaction) {
     if (result != libdnf5::base::Transaction::TransactionRunResult::SUCCESS) {
         print_error(libdnf5::utils::sformat(
             _("Transaction failed: {}"), libdnf5::base::Transaction::transaction_result_to_string(result)));
+
+        // For transaction lock errors, provide detailed information about the running transaction
+        if (result == libdnf5::base::Transaction::TransactionRunResult::ERROR_LOCK) {
+            auto active_info = base.get_active_transaction_info();
+            if (active_info) {
+                print_error(_("Details about the currently running transaction:"));
+                auto info_str = format_active_transaction_info(*active_info);
+                if (!info_str.empty()) {
+                    // Print each line of the formatted info with proper indentation
+                    std::istringstream ss(info_str);
+                    std::string line;
+                    while (std::getline(ss, line)) {
+                        print_error(libdnf5::utils::sformat(_("  {}"), line));
+                    }
+                }
+            }
+        }
+
         for (auto const & entry : transaction.get_gpg_signature_problems()) {
             print_error(entry);
         }
@@ -530,6 +591,19 @@ void Context::Impl::download_and_run(libdnf5::base::Transaction & transaction) {
     if (result != libdnf5::base::Transaction::TransactionRunResult::SUCCESS) {
         print_error(libdnf5::utils::sformat(
             _("Transaction failed: {}"), libdnf5::base::Transaction::transaction_result_to_string(result)));
+
+        // For transaction lock errors, provide detailed information about the running transaction
+        if (result == libdnf5::base::Transaction::TransactionRunResult::ERROR_LOCK) {
+            auto active_info = base.get_active_transaction_info();
+            if (active_info) {
+                auto info_str = format_active_transaction_info(*active_info);
+                if (!info_str.empty()) {
+                    print_error(_("Details about the currently running transaction:"));
+                    print_error(info_str);
+                }
+            }
+        }
+
         for (auto const & entry : transaction.get_gpg_signature_problems()) {
             print_error(entry);
         }