Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Editor #8

Open
chutchinson opened this issue May 15, 2015 · 4 comments
Open

Item Editor #8

chutchinson opened this issue May 15, 2015 · 4 comments

Comments

@chutchinson
Copy link
Contributor

Implement the item editor with all of the existing features from version 3.x. Should be a paragon of the asset pipeline implementation.

@goblinJoel
Copy link
Contributor

Suggestion: Consider changing how default equipment slots, animations, and idle animations work. For example, the user could add rows of equipment slots for their game, giving each one a name and ordering them. Then, the item editor could automatically show those options for which equipment slots it can apply to. Animations could work the same way.

I've moved the default equipment slot, standard animation, and standing animation counts (which were used to initialize those lists with a certain number of blank/false elements) into the legacy item serializer, since it seems like those are more a limitation of the way the binary formats were coded than a design philosophy that we want to keep. This also means that those lists are empty on creation instead of having blank/false elements added by default.

If you need to see the old way for comparison or reverting (please don't revert the whole commit; there's other stuff in it!), the commit where I pulled this stuff out of the item asset class is rpgtoolkit/core@5d05b56 .

@goblinJoel
Copy link
Contributor

goblinJoel commented Nov 23, 2016

Note: I found two commits from May 2015 from @chutchinson for the item editor on branch editor-item, but I don't see them or that branch here on github. Was that abandoned?

Revisions: d8fdfb5 and dd73ff3

@goblinJoel
Copy link
Contributor

Pinging @swordmaster2k . Do we want to use the commits I mentioned above as the basis for the item editor?

@goblinJoel
Copy link
Contributor

Swordmaster believes that, after some of the changes and the sprite editor UI centralization, it would be easiest to base the item editor off of CharacterEditor.java.

swordmaster2k added a commit that referenced this issue Jan 9, 2017
…' editors to centralise some of the code.

Leaving the ItemEditor as barebones implementation until file formats are reviewed.

#8

Signed-off-by: Joshua Michael Daly <b00056835@student.itb.ie>
swordmaster2k added a commit that referenced this issue Jan 9, 2017
#8

Signed-off-by: Joshua Michael Daly <b00056835@student.itb.ie>
swordmaster2k added a commit that referenced this issue Jan 10, 2017
…' editors to centralise some of the code.

Leaving the ItemEditor as barebones implementation until file formats are reviewed.

#8

Signed-off-by: Joshua Michael Daly <b00056835@student.itb.ie>
swordmaster2k added a commit that referenced this issue Jan 10, 2017
#8

Signed-off-by: Joshua Michael Daly <b00056835@student.itb.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants