Set CXX standard to 17 (#635)

The codecvt library is marked as deprecated in MSVC, but has no replacement in the standard. According to the deprecation notice, the library will not be removed until a suitable replacement has been standardized. In order to avoid pulling in additional third party libraries, the deprecation warning is disabled until the time comes that a replacement can be made (probably C++23)

Signed-off-by: Øystein Sture <[email protected]>

Author: oysstu

rosidl_generator_cpp/CMakeLists.txt

@@ -34,9 +34,9 @@ if(BUILD_TESTING)
     SKIP_INSTALL
   )
 
-  # Default to C++14
+  # Default to C++17
   if(NOT CMAKE_CXX_STANDARD)
-    set(CMAKE_CXX_STANDARD 14)
+    set(CMAKE_CXX_STANDARD 17)
   endif()
 
   if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")

rosidl_runtime_c/CMakeLists.txt

@@ -59,9 +59,9 @@ if(BUILD_TESTING)
 
   # For gtest
   enable_language(CXX)
-  # Default to C++14
+  # Default to C++17
   if(NOT CMAKE_CXX_STANDARD)
-    set(CMAKE_CXX_STANDARD 14)
+    set(CMAKE_CXX_STANDARD 17)
   endif()
 
   find_package(ament_cmake_gtest REQUIRED)

rosidl_runtime_cpp/CMakeLists.txt

@@ -9,6 +9,11 @@ target_include_directories(${PROJECT_NAME} INTERFACE
   "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
   "$<INSTALL_INTERFACE:include>")
 
+if(MSVC)
+  target_compile_definitions(${PROJECT_NAME} INTERFACE
+  _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING)
+endif()
+
 ament_export_include_directories(include)
 ament_export_targets(${PROJECT_NAME})
 
@@ -25,9 +30,9 @@ if(BUILD_TESTING)
 
   find_package(ament_cmake_gtest REQUIRED)
 
-  # Default to C++14
+  # Default to C++17
   if(NOT CMAKE_CXX_STANDARD)
-    set(CMAKE_CXX_STANDARD 14)
+    set(CMAKE_CXX_STANDARD 17)
   endif()
 
   if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")

rosidl_typesupport_interface/CMakeLists.txt

@@ -21,9 +21,9 @@ if(BUILD_TESTING)
   if(NOT CMAKE_C_STANDARD)
     set(CMAKE_C_STANDARD 11)
   endif()
-  # Default to C++14
+  # Default to C++17
   if(NOT CMAKE_CXX_STANDARD)
-    set(CMAKE_CXX_STANDARD 14)
+    set(CMAKE_CXX_STANDARD 17)
   endif()
 
   find_package(ament_cmake_gtest REQUIRED)

rosidl_typesupport_introspection_cpp/CMakeLists.txt

@@ -2,9 +2,9 @@ cmake_minimum_required(VERSION 3.12)
 
 project(rosidl_typesupport_introspection_cpp)
 
-# Default to C++14
+# Default to C++17
 if(NOT CMAKE_CXX_STANDARD)
-  set(CMAKE_CXX_STANDARD 14)
+  set(CMAKE_CXX_STANDARD 17)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")

rosidl_typesupport_introspection_cpp/cmake/rosidl_typesupport_introspection_cpp_generate_interfaces.cmake

@@ -98,7 +98,7 @@ if(WIN32)
 endif()
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
   set_target_properties(${rosidl_generate_interfaces_TARGET}${_target_suffix} PROPERTIES
-    CXX_STANDARD 14
+    CXX_STANDARD 17
     COMPILE_OPTIONS -Wall -Wextra -Wpedantic
   )
 endif()