From ed3d4e4162a3dc00d6ce2517c1ffa2ba1325059d Mon Sep 17 00:00:00 2001 From: Janosch Machowinski Date: Tue, 5 Dec 2023 08:05:50 +0000 Subject: [PATCH] fix: fixed namespace collision warning in test Signed-off-by: Janosch Machowinski --- rosbag2_compression/CMakeLists.txt | 4 ++-- .../test/rosbag2_compression/fake_compression_factory.hpp | 2 +- .../test/rosbag2_compression/fake_compressor.hpp | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/rosbag2_compression/CMakeLists.txt b/rosbag2_compression/CMakeLists.txt index 9bb9a9e795..0376daa247 100644 --- a/rosbag2_compression/CMakeLists.txt +++ b/rosbag2_compression/CMakeLists.txt @@ -104,10 +104,10 @@ if(BUILD_TESTING) ) ament_add_gmock(test_sequential_compression_writer - test/rosbag2_compression/test_sequential_compression_writer.cpp - test/rosbag2_compression/fake_compressor.cpp) + test/rosbag2_compression/test_sequential_compression_writer.cpp) target_link_libraries(test_sequential_compression_writer ${PROJECT_NAME} + fake_plugin rosbag2_cpp::rosbag2_cpp rosbag2_storage::rosbag2_storage ) diff --git a/rosbag2_compression/test/rosbag2_compression/fake_compression_factory.hpp b/rosbag2_compression/test/rosbag2_compression/fake_compression_factory.hpp index d023789462..3a4908d519 100644 --- a/rosbag2_compression/test/rosbag2_compression/fake_compression_factory.hpp +++ b/rosbag2_compression/test/rosbag2_compression/fake_compression_factory.hpp @@ -21,7 +21,7 @@ #include "rosbag2_compression/compression_factory.hpp" #include "fake_compressor.hpp" -class FakeCompressionFactory +class ROSBAG2_COMPRESSION_PUBLIC FakeCompressionFactory : public rosbag2_compression::CompressionFactory { public: diff --git a/rosbag2_compression/test/rosbag2_compression/fake_compressor.hpp b/rosbag2_compression/test/rosbag2_compression/fake_compressor.hpp index 492958c3ec..f13492bd60 100644 --- a/rosbag2_compression/test/rosbag2_compression/fake_compressor.hpp +++ b/rosbag2_compression/test/rosbag2_compression/fake_compressor.hpp @@ -20,7 +20,8 @@ #include "rosbag2_compression/base_compressor_interface.hpp" #include "rosbag2_storage/serialized_bag_message.hpp" -class FakeCompressor : public rosbag2_compression::BaseCompressorInterface +class ROSBAG2_COMPRESSION_PUBLIC FakeCompressor : public rosbag2_compression:: + BaseCompressorInterface { public: FakeCompressor() = default;