Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulation time in log messages #487

Open
asherikov opened this issue Jan 20, 2025 · 1 comment
Open

simulation time in log messages #487

asherikov opened this issue Jan 20, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@asherikov
Copy link

ROS1 could output log messages with simulation clock timestamps http://wiki.ros.org/rosconsole#Console_Output_Formatting, which does not seem to be supported in ROS2 https://github.com/ros2/rcutils/blob/rolling/include/rcutils/logging.h#L62, but could be useful.

@fujitatomoya
Copy link
Collaborator

IMO this can be useful for the application that uses simulation clock.

currently this is not supported, rcutils logging macro is not aware of simulation time (nor node object), so the application needs to fill the simulation clock time in the logging data payload with their responsibility. client logging macros (rclcpp, rclpy and rcl) are actually aliases to rcutils logging macros. So for doing this, client logging macros need to be responsible to fetch the simulation clock if that is available, and fill that in the logging data payload and formatted by rcutils. (i am not sure if this is the best way to do that, but something i think of.)

@fujitatomoya fujitatomoya added the enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants