From e16b8f9d8e6283ce5433c6ed900af0a3959a0e4c Mon Sep 17 00:00:00 2001 From: Janosch Machowinski Date: Mon, 2 Dec 2024 17:53:32 +0100 Subject: [PATCH] fix: Deprecate broken API Signed-off-by: Janosch Machowinski --- rclcpp/include/rclcpp/clock.hpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/rclcpp/include/rclcpp/clock.hpp b/rclcpp/include/rclcpp/clock.hpp index 6cbbed5d18..874ac04a56 100644 --- a/rclcpp/include/rclcpp/clock.hpp +++ b/rclcpp/include/rclcpp/clock.hpp @@ -194,12 +194,17 @@ class Clock ros_time_is_active(); /** + * Deprecated. This API is broken, as there is no way to get a deep + * copy of a clock. Therefore one can experience spurious wakeups triggered + * by some other instance of a clock. + * * Cancels an ongoing or future sleep operation of one thread. * * This function can be used by one thread, to wakeup another thread that is * blocked using any of the sleep_ or wait_ methods of this class. */ RCLCPP_PUBLIC + [[deprecated("Use ClockConditionalVariable")]] void cancel_sleep_or_wait();