From 19773973a80d753c6fa028b0b548462fbbef122d Mon Sep 17 00:00:00 2001 From: LihanChen2004 <74599182+LihanChen2004@users.noreply.github.com> Date: Mon, 30 Dec 2024 07:51:58 +0800 Subject: [PATCH] Redundant .c_str() usage in rclcpp_components triggers ament_clang_tidy warning (#2718) * fix: Simplify string assignment for class name in node_main.cpp.in Signed-off-by: LihanChen2004 <757003373@qq.com> * Remove redundant local variable `name` Co-authored-by: Tomoya Fujita Signed-off-by: LihanChen2004 <74599182+LihanChen2004@users.noreply.github.com> --------- Signed-off-by: LihanChen2004 <757003373@qq.com> Signed-off-by: LihanChen2004 <74599182+LihanChen2004@users.noreply.github.com> Co-authored-by: Tomoya Fujita --- rclcpp_components/src/node_main.cpp.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/rclcpp_components/src/node_main.cpp.in b/rclcpp_components/src/node_main.cpp.in index 0ca5eb8c61..1d39c855e4 100644 --- a/rclcpp_components/src/node_main.cpp.in +++ b/rclcpp_components/src/node_main.cpp.in @@ -40,8 +40,7 @@ int main(int argc, char * argv[]) auto loader = new class_loader::ClassLoader(library_name); auto classes = loader->getAvailableClasses(); for (const auto & clazz : classes) { - std::string name = clazz.c_str(); - if (name.compare(class_name) == 0) { + if (clazz.compare(class_name) == 0) { RCLCPP_DEBUG(logger, "Instantiate class %s", clazz.c_str()); std::shared_ptr node_factory = nullptr; try {