Update CMakeLists.txt to not use genmsg #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The beginner tutorial for this repo was using a dependency on genmsg instead of message_generation which causes a lot of confusion as the tutorial for msg files, for actionlib and the docs for CMakeLists.txt say to use message_generation and not genmsg
add_dependencies macro was using an explicit {project_name}_generated_messages_cpp dependency whereas the CMakeLists.txt documentation specifies to use ${catkin_EXPORTED_TARGETS}, which also causes confusion right in the beginning
This problem has been raised in the ROS QA forum many times and is still not being changed
Thank You
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beginner tutorial for this repo was using a dependency on genmsg instead of message_generation which causes a lot of confusion as the tutorial for msg files, for actionlib and the docs for CMakeLists.txt say to use message_generation and not genmsg
add_dependencies macro was using an explicit {project_name}_generated_messages_cpp dependency whereas the CMakeLists.txt documentation specifies to use ${catkin_EXPORTED_TARGETS}, which also causes confusion right in the beginning
I understand this edit is very minor but it seems to be a very common problem beginners have with the tutorial
This problem has been raised in the ROS QA forum many times but is still not changed
Thank You