Skip to content

Conversation

@christophfroehlich
Copy link
Member

Remove linters from build stage, as we have it in the pre-commit config.

For context see ros-controls/control_msgs#247 (comment)

@ahcorde do you have an idea why this fails in the ros-buildfarm pre-release script, but does not fail on the buildfarm itself?

@christophfroehlich christophfroehlich changed the title Remove linters from build stage Remove linters from test stage Sep 3, 2025
@christophfroehlich
Copy link
Member Author

@Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2025

backport kilted jazzy humble

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

)

# Testing and linting
if(BUILD_TESTING)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this too ?

@ahcorde
Copy link
Collaborator

ahcorde commented Sep 4, 2025

Remove linters from build stage, as we have it in the pre-commit config.

For context see ros-controls/control_msgs#247 (comment)

@ahcorde do you have an idea why this fails in the ros-buildfarm pre-release script, but does not fail on the buildfarm itself?

No ideas, why this might happen. @j-rivero ?

@christophfroehlich
Copy link
Member Author

I opened an issue in the buildfarm repo: ros-infrastructure/ros_buildfarm#1098

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Oct 24, 2025
@github-actions github-actions bot removed the stale label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants