Skip to content

Fixes for use of internal, low-level compression functions #20751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jblomer wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fixes for use of internal, low-level compression functions #20751

jblomer wants to merge 9 commits into from
+469 −148

Conversation

@jblomer
Copy link
Contributor

@jblomer jblomer commented Dec 18, 2025 •
edited
Loading

Fixes #20750

PR Status:

  • unit test infrastructure to test zip header corruption
  • fix unzipping in RNTuple
  • fix unzipping in TKey
  • fix unzipping in TBasket
  • fix unzipping in TTreeCache
  • fix unzipping in TMessage
  • fix unzipping in TBufferXML

@jblomer jblomer self-assigned this Dec 18, 2025
@jblomer jblomer added the in:I/O label Dec 18, 2025
@jblomer jblomer marked this pull request as draft December 18, 2025 08:43
@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Test Results

    22 files      22 suites   3d 22h 21m 37s ⏱️
 3 812 tests  3 812 ✅ 0 💤 0 ❌
76 754 runs  76 754 ✅ 0 💤 0 ❌

Results for commit f27211b.

♻️ This comment has been updated with latest results.

@jblomer jblomer added the clean build Ask CI to do non-incremental build on PR label Dec 19, 2025
@jblomer jblomer force-pushed the io-fix-unzip branch 3 times, most recently from 8010b13 to d91e965 Compare January 15, 2026 20:00
@jblomer jblomer marked this pull request as ready for review January 16, 2026 11:27
@jblomer
Copy link
Contributor Author

jblomer commented Jan 16, 2026 •
edited
Loading

@pcanal: Regarding TBufferXML: do you by chance know how XmlWriteBlock and XmlReadBlock is reached? Trying this with a TXMLFile, XmlWriteBlock backs out immediately because Length() is zero.

@pcanal
Copy link
Member

pcanal commented Jan 16, 2026

Regarding TBufferXML: do you by chance know how XmlWriteBlock and XmlReadBlock is reached? Trying this with a TXMLFile, XmlWriteBlock backs out immediately because Length() is zero.

@linev might be able to confirm but it looks like it is currently not used per se. (In our tests, it is being called but, as you mentioned, it returns immediately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jblomer jblomer

Labels

clean build Ask CI to do non-incremental build on PR in:I/O

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Insufficient checks around R__unzip_header

2 participants

@jblomer @pcanal