Grout halfway identifying downloaded roms

[asc6]

Describe the bug
Hello, thank you for this awesome app! I’ve been using it for several months and noticed a few versions ago that it seems to completely lose its mind after an update and begins ignoring your save files. I was hoping this would maybe get fixed in 4.9 however it seems to be operating the exact same. Wanted to make an issue since I think this is a bug and not something I’m just doing wrong suddenly.

Reproduction Steps

1. Download Grout
2. Download a game through Grout
3. Play the game to make a save file
4. Sync the save by launching Grout
5. Update or Delete the Grout app
6. Re-launch Grout and log back in
7. Observe that the save sync feature is completely oblivious to installed games and save files
8. Also observe that the game is still correctly marked as downloaded and gives you the option to redownload
9. redownload the same game as step 2
10. Save your game to update the local save file
11. launch Grout and see that it will refuse to sync or even acknowledge the safe file’s existence

Expected Behavior
Grout intelligently knows if a rom file itself is installed, but the save feature doesn’t have this same intelligence. I expect both methods to identify a game/save would be consistent. I have attached a log file from my device and you can see where it recognizes saves but doesn’t match them to roms. I then use Grout to redownload “ Kingdom Hearts - Chain of Memories (Europe) (En,Fr,De,Es,It)” and it shows up in the log and the name is the exact same as the save file but yet even then a save sync still says no match.

app.log

Information

• CFW: MuOS
• CFW Version: 2601.1 Funky Jacaranda (aeaacd43)
• Handheld Device: Anbernic RG 40XXV
• Grout Version: 4.9.0-beta.3
• RomM Version: 4.9.0

[pawndev]

Thanks for the report !
The save sync feature was something with many issues in this, and the with the new save-sync in RomM v4.9.0 it will surely be better, but nothing really stable as of now.
Your feedback will be helpful when continuing/investigating on this feature !

[BrandonKowalski]

@asc6 please give v4.9.0-beta.4 a try! Pretty confident that I tracked this down.

[asc6]

@BrandonKowalski Closer for sure! Here’s a new log file

app_6-17.log

. Do note that I manually updated Grout since the self-update feature doesn’t see a new beta release for v4.9.1 (and now .2) of Romm

In this log it shows that it identified several save files and properly uploaded them as expected. However the detection missed two saves as far as I can tell.

Success

• /run/muos/storage/save/file/mGBA/Kingdom Hearts - Chain of Memories (Europe) (En,Fr,De,Es,It).srm
• /run/muos/storage/save/file/mGBA/Metroid_ Scrolls 6 (1.1).srm
• /run/muos/storage/save/file/mGBA/Pokémon Heart & Soul (v1.2.1) (Hack).srm
• /run/muos/storage/save/file/mGBA/Petz - Hamsterz Life 2 (USA).srm

Not found/synced
File: /mnt/union/ROMS/gba/Legend of Zelda, The - The Minish Cap (USA).gba
Save: /run/muos/storage/save/file/mGBA/Legend of Zelda, The - The Minish Cap (USA).srm

File: /mnt/union/ROMS/snes/Donkey Kong Country (USA) (Rev 2).sfc
Save: /run/muos/storage/save/file/Snes9x/Donkey Kong Country (USA) (Rev 2).srm

The Donkey Kong save is probably the same one as on the server so maybe there’s some reasoning as to why, but the log doesn’t seem to indicate a match as far as I can tell. No clue on why Minish Cap didn’t match. I’ll continue testing some more and see if I can make heads or tails of why the difference. Happy to gather any more information needed.

[asc6]

OK after testing on a few devices I think I narrowed down the improvement and the gap. It seems that if RomM has multiple files under the same game entry (picture) then “expected_basename” only lists one of these files names in the DB cell. Using Donkey Kong Country as an example you get the following results.

• name: “Donkey Kong Country”
• fs_name: “Donkey Kong Country”
• fs_name_no_ext: “Donkey Kong Country”
• expected_basename: “Donkey Kong Country (Europe)(En,Fr,De)(Rev 1)”

Using the log above for reference then the save file "Donkey Kong Country (USA) (Rev 2).srm" fails to match the expected_basename. Other ROM files that don’t have multiple versions seem to have a flawless sync on this latest beta, much better than the other versions at least.

[BrandonKowalski]

This is super helpful! I'll take a look later this weekend.