Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :verbose in s:toggle_global_golden_ratio to echo current value #18

Open
Konfekt opened this issue Apr 18, 2014 · 2 comments
Open

Comments

@Konfekt
Copy link

Konfekt commented Apr 18, 2014

Looking at your script, this variable is only used at startup. Afterwards, only a script variable.

I would like to use g:golden_ratio_autocommand for visual feedback when toggling (echo g:golden_ratio_autocommand), so how about using this one instead?

@idbrii
Copy link
Collaborator

idbrii commented Dec 17, 2016

s:toggle_global_golden_ratio would break if we used that value and someone changed it directly instead of calling s:toggle_global_golden_ratio().

Maybe that could be an exposed function that returns the new value, but definitely don't want to expose the variable.

I think vim has a way for code to see if they were called with :verbose. Using that to echo on toggle sounds good. What do you think?

@Konfekt
Copy link
Author

Konfekt commented Dec 18, 2016

Sounds good/

@idbrii idbrii changed the title use g:golden_ratio_autocommand Support :verbose in s:toggle_global_golden_ratio to echo current value Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants