Skip to content

Commit e850bb0

Browse files
Merge pull request #14 from rollbar/revert-11-master
Revert "Prevent boot/register if $level == none"
2 parents 9c42eef + f3cb96d commit e850bb0

File tree

1 file changed

+7
-22
lines changed

1 file changed

+7
-22
lines changed

src/RollbarServiceProvider.php

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class RollbarServiceProvider extends ServiceProvider
2020
public function boot()
2121
{
2222
// Don't boot rollbar if it is not configured.
23-
if ($this->stop() === true) {
23+
if (! getenv('ROLLBAR_TOKEN') and ! $this->app['config']->get('services.rollbar')) {
2424
return;
2525
}
2626

@@ -51,50 +51,35 @@ public function boot()
5151
public function register()
5252
{
5353
// Don't register rollbar if it is not configured.
54-
if ($this->stop() === true) {
54+
if (! getenv('ROLLBAR_TOKEN') and ! $this->app['config']->get('services.rollbar')) {
5555
return;
5656
}
5757

5858
$app = $this->app;
5959

6060
$this->app->singleton('Rollbar\RollbarLogger', function ($app) {
61-
61+
6262
$defaults = [
6363
'environment' => $app->environment(),
6464
'root' => base_path(),
6565
];
6666
$config = array_merge($defaults, $app['config']->get('services.rollbar', []));
6767
$config['access_token'] = getenv('ROLLBAR_TOKEN') ?: $app['config']->get('services.rollbar.access_token');
68-
68+
6969
if (empty($config['access_token'])) {
7070
throw new InvalidArgumentException('Rollbar access token not configured');
7171
}
72-
72+
7373
\Rollbar\Rollbar::init($config);
74-
74+
7575
return Rollbar::logger();
7676
});
7777

7878
$this->app->singleton('Rollbar\Laravel\RollbarLogHandler', function ($app) {
79-
79+
8080
$level = getenv('ROLLBAR_LEVEL') ?: $app['config']->get('services.rollbar.level', 'debug');
8181

8282
return new RollbarLogHandler($app['Rollbar\RollbarLogger'], $app, $level);
8383
});
8484
}
85-
86-
/**
87-
* Check if we should prevent the service from registering
88-
*
89-
* @return boolean
90-
*/
91-
public function stop()
92-
{
93-
$level = getenv('ROLLBAR_LEVEL') ?: $this->app->config->get('services.rollbar.level', null);
94-
$hasLevel = empty($level) === false || strtolower($level) != 'none';
95-
$hasToken = getenv('ROLLBAR_TOKEN');
96-
$hasConfig = $this->app['config']->has('services.rollbar');
97-
98-
return $hasLevel === false || ($hasToken === false && $hasConfig === false);
99-
}
10085
}

0 commit comments

Comments
 (0)