Skip to content

Commit 33da865

Browse files
authored
Updated composer update if statement
This explicitly checks the previous step before `continue-on-error: true` is applied.
1 parent cdbd5f7 commit 33da865

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ jobs:
6868
run: composer create-project laravel/laravel rollbar-test-app ${{ matrix.laravel }}
6969

7070
- name: Install that code using Composer rigged to look in the parent directory
71+
id: composer_require
7172
working-directory: rollbar-test-app
7273
continue-on-error: true
7374
run: |
@@ -77,7 +78,7 @@ jobs:
7778
- name: Try to resolve requirements into an installable set of packages
7879
working-directory: rollbar-test-app
7980
# This adds time, so only run this if the previous step fails.
80-
if: ${{ failure() }}
81+
if: ${{ steps.composer_require.outcome == 'failure' }}
8182
run: composer update
8283

8384
- name: Setup .env

0 commit comments

Comments
 (0)