Skip to content

bug(page-manager): isLoading can stick and silently kill all navigation #322

@roiguri

Description

@roiguri

Source: Deep code review — docs/code-review-2026-05.md (finding B2, P1).

Where: src/app/core/page-manager.js:14-47

Issue: If unloadCurrentPage() or render() throws, isLoading is never reset, so every subsequent navigation is silently dropped — the app appears frozen with no error surfaced.

Fix: Wrap navigation in try { ... } finally { this.isLoading = false; }.

Cheap, high-payoff stability fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions