Skip to content

Conversation

@chhtz
Copy link
Member

@chhtz chhtz commented Nov 21, 2025

Under Ubuntu 20.04 this fixes deprecation warnings:

/opt/workspace/tools/orogen/lib/orogen/gen/templates.rb:54: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/opt/workspace/tools/orogen/lib/orogen/gen/templates.rb:54: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
/opt/workspace/tools/orogen/lib/orogen/gen/templates.rb:54: warning: Passing eoutvar with the 4th argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, eoutvar: ...) instead.
/opt/workspace/tools/orogen/lib/orogen/gen/templates.rb:54: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.

For Ubuntu 24.04 without this change, orogen recently ceased to work.

@chhtz
Copy link
Member Author

chhtz commented Nov 21, 2025

I see, this is also part of https://github.com/rock-core/tools-orogen/pull/24/files#diff-cece380362aad64378ea51e2369b144289bc56119ef2977d35e4bcef28563d79L54
So feel free to close this (preferably after merging #24)

Copy link
Contributor

@jhonasiv jhonasiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doudou anything holding up the merge of #24? If so, then I think this could be merged

@chhtz
Copy link
Member Author

chhtz commented Dec 4, 2025

@doudou anything holding up the merge of #24? If so, then I think this could be merged

Merging this will conflict with merging #24 later. If something is blocking #24 I could cherry-pick the relevant commits.
I did not extensively test #24, I think I had some problems on Ubuntu 24.04 (I also needed to merge in changes for Qt5 compatibility, which may have caused issues), but I'd need to test this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants