New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully automate vendor maven updates #14

Open

TheTripleV opened this issue Jan 18, 2022 · 1 comment

Member

TheTripleV commented Jan 18, 2022

Basically,

Check for update
try:
Run scan headers
Build
Run Gen Imports
Rebuild
Create PR
Except:
Create Issue

Member

virtuald commented Jan 19, 2022

This is a worthy goal, and definitely seems doable for in-season updates. Some things standing in the way:

scan-headers doesn't modify pyproject.toml. Will want to use tomlkit for this, to ensure that existing format/comments are kept in the file.
You forgot about create-gen --write... though I guess it's not strictly necessary. It would also be nice if create-gen could modify the existing yaml files.
gen-imports doesn't modify __init__.py either, and there are some cases where imports are conditional. Would need a way to specify these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment