pr feedback

Author: sberan

roboflow/core/workspace.py

@@ -287,7 +287,7 @@ def upload_dataset(
         project_type: str = "object-detection",
         batch_name=None,
         num_retries=0,
-        are_predictions=False,
+        is_prediction=False,
     ):
         """
         Upload a dataset to Roboflow.
@@ -301,7 +301,7 @@ def upload_dataset(
             project_type (str): type of the project (only `object-detection` is supported)
             batch_name (str, optional): name of the batch to upload the images to. Defaults to an automatically generated value.
             num_retries (int, optional): number of times to retry uploading an image if the upload fails. Defaults to 0.
-            are_predictions (bool, optional): whether the annotations provided in the dataset are predictions and not ground truth. Defaults to False.
+            is_prediction (bool, optional): whether the annotations provided in the dataset are predictions and not ground truth. Defaults to False.
         """  # noqa: E501 // docs
         if dataset_format != "NOT_USED":
             print("Warning: parameter 'dataset_format' is deprecated and will be removed in a future release")
@@ -356,7 +356,7 @@ def _upload_image(imagedesc):
                 sequence_number=imagedesc.get("index"),
                 sequence_size=len(images),
                 num_retry_uploads=num_retries,
-                is_prediction=are_predictions,
+                is_prediction=is_prediction,
             )
 
             return image, upload_time, upload_retry_attempts

tests/test_project.py

@@ -379,7 +379,7 @@ def test_project_upload_dataset(self):
                     {"file": "pred1.jpg", "split": "train", "annotationfile": {"file": "pred1.xml"}},
                     {"file": "pred2.jpg", "split": "valid", "annotationfile": {"file": "pred2.xml"}},
                 ],
-                "params": {"are_predictions": True},
+                "params": {"is_prediction": True},
                 "assertions": {
                     "upload": {"count": 2, "kwargs": {"is_prediction": True}},
                     "save_annotation": {"count": 2},
@@ -390,7 +390,7 @@ def test_project_upload_dataset(self):
                 "dataset": [
                     {"file": "gt1.jpg", "split": "train", "annotationfile": {"file": "gt1.xml"}},
                 ],
-                "params": {"are_predictions": False},
+                "params": {"is_prediction": False},
                 "assertions": {
                     "upload": {"count": 1, "kwargs": {"is_prediction": False}},
                     "save_annotation": {"count": 1},
@@ -402,7 +402,7 @@ def test_project_upload_dataset(self):
                     {"file": "batch_pred.jpg", "split": "train", "annotationfile": {"file": "batch_pred.xml"}},
                 ],
                 "params": {
-                    "are_predictions": True,
+                    "is_prediction": True,
                     "batch_name": "prediction-batch",
                     "num_retries": 2,
                 },