Skip to content

Commit 7642e67

Browse files
author
Howard Lewis Ship
committed
Work around a TestNG bug by moving test cases to a sub-package of org.apache.tapestry5.
git-svn-id: https://svn.apache.org/repos/asf/tapestry/tapestry5/trunk@892333 13f79535-47bb-0310-9956-ffa450edef68
1 parent c3bd84d commit 7642e67

File tree

14 files changed

+36
-16
lines changed

14 files changed

+36
-16
lines changed

tapestry-core/src/test/conf/testng.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</test>
2525
<test name="Public APIs" enabled="true">
2626
<packages>
27-
<package name="org.apache.tapestry5"/>
27+
<package name="org.apache.tapestry5.root"/>
2828
<package name="org.apache.tapestry5.dom"/>
2929
<package name="org.apache.tapestry5.json"/>
3030
<package name="org.apache.tapestry5.runtime"/>

tapestry-core/src/test/java/org/apache/tapestry5/integration/reload/ReloadTests.java

+13-3
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,23 @@
1414

1515
package org.apache.tapestry5.integration.reload;
1616

17-
import javassist.*;
17+
import java.io.BufferedInputStream;
18+
import java.io.BufferedOutputStream;
19+
import java.io.File;
20+
import java.io.FileOutputStream;
21+
import java.io.IOException;
22+
import java.io.InputStream;
23+
24+
import javassist.CannotCompileException;
25+
import javassist.ClassPool;
26+
import javassist.CtClass;
27+
import javassist.CtMethod;
28+
import javassist.NotFoundException;
29+
1830
import org.apache.tapestry5.internal.TapestryInternalUtils;
1931
import org.apache.tapestry5.test.AbstractIntegrationTestSuite;
2032
import org.testng.annotations.Test;
2133

22-
import java.io.*;
23-
2434
/**
2535
* Integration tests designed to test Tapestry's ability to dynamically reload component classes,
2636
* templates and message

tapestry-core/src/test/java/org/apache/tapestry5/internal/bindings/ValidateBindingFactoryTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616

1717
import org.apache.tapestry5.Binding;
1818
import org.apache.tapestry5.ComponentResources;
19-
import org.apache.tapestry5.FieldComponent;
2019
import org.apache.tapestry5.FieldValidator;
2120
import org.apache.tapestry5.internal.services.StringInterner;
2221
import org.apache.tapestry5.internal.services.StringInternerImpl;
2322
import org.apache.tapestry5.internal.test.InternalBaseTestCase;
2423
import org.apache.tapestry5.ioc.Location;
2524
import org.apache.tapestry5.ioc.internal.util.TapestryException;
25+
import org.apache.tapestry5.root.FieldComponent;
2626
import org.apache.tapestry5.runtime.Component;
2727
import org.apache.tapestry5.services.BindingFactory;
2828
import org.apache.tapestry5.services.FieldValidatorSource;

tapestry-core/src/test/java/org/apache/tapestry5/internal/services/FieldTranslatorSourceImplTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import org.apache.tapestry5.internal.test.InternalBaseTestCase;
1919
import org.apache.tapestry5.ioc.MessageFormatter;
2020
import org.apache.tapestry5.ioc.Messages;
21+
import org.apache.tapestry5.root.FieldComponent;
2122
import org.apache.tapestry5.services.FieldTranslatorSource;
2223
import org.apache.tapestry5.services.FormSupport;
2324
import org.apache.tapestry5.services.TranslatorSource;

tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import org.apache.tapestry5.model.ComponentModel;
3535
import org.apache.tapestry5.model.EmbeddedComponentModel;
3636
import org.apache.tapestry5.model.MutableComponentModel;
37+
import org.apache.tapestry5.root.FieldComponent;
3738
import org.apache.tapestry5.runtime.Component;
3839
import org.apache.tapestry5.runtime.RenderCommand;
3940
import org.apache.tapestry5.runtime.RenderQueue;

tapestry-core/src/test/java/org/apache/tapestry5/ContentTypeTest.java renamed to tapestry-core/src/test/java/org/apache/tapestry5/root/ContentTypeTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package org.apache.tapestry5;
15+
package org.apache.tapestry5.root;
1616

17+
import org.apache.tapestry5.ContentType;
1718
import org.testng.Assert;
1819
import org.testng.annotations.Test;
1920

tapestry-core/src/test/java/org/apache/tapestry5/FieldComponent.java renamed to tapestry-core/src/test/java/org/apache/tapestry5/root/FieldComponent.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package org.apache.tapestry5;
15+
package org.apache.tapestry5.root;
1616

17+
import org.apache.tapestry5.Field;
1718
import org.apache.tapestry5.runtime.Component;
1819

1920
/**

tapestry-core/src/test/java/org/apache/tapestry5/MarkupUtilsTest.java renamed to tapestry-core/src/test/java/org/apache/tapestry5/root/MarkupUtilsTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package org.apache.tapestry5;
15+
package org.apache.tapestry5.root;
1616

17+
import org.apache.tapestry5.MarkupUtils;
1718
import org.testng.Assert;
1819
import org.testng.annotations.DataProvider;
1920
import org.testng.annotations.Test;

tapestry-core/src/test/java/org/apache/tapestry5/Stooge.java renamed to tapestry-core/src/test/java/org/apache/tapestry5/root/Stooge.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package org.apache.tapestry5;
15+
package org.apache.tapestry5.root;
1616

1717
public enum Stooge
1818
{

tapestry-core/src/test/java/org/apache/tapestry5/ValidationTrackerImplTest.java renamed to tapestry-core/src/test/java/org/apache/tapestry5/root/ValidationTrackerImplTest.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,11 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package org.apache.tapestry5;
15+
package org.apache.tapestry5.root;
1616

17+
import org.apache.tapestry5.Field;
18+
import org.apache.tapestry5.ValidationTracker;
19+
import org.apache.tapestry5.ValidationTrackerImpl;
1720
import org.apache.tapestry5.test.TapestryTestCase;
1821
import org.testng.annotations.Test;
1922

tapestry-core/src/test/java/org/apache/tapestry5/VersionUtilsTest.java renamed to tapestry-core/src/test/java/org/apache/tapestry5/root/VersionUtilsTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
package org.apache.tapestry5;
1+
package org.apache.tapestry5.root;
22

3+
import org.apache.tapestry5.VersionUtils;
34
import org.testng.Assert;
45
import org.testng.annotations.Test;
56

tapestry-core/src/test/java/org/apache/tapestry5/util/EnumSelectModelTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
import org.apache.tapestry5.OptionModel;
1818
import org.apache.tapestry5.SelectModel;
19-
import org.apache.tapestry5.Stooge;
2019
import org.apache.tapestry5.ioc.Messages;
20+
import org.apache.tapestry5.root.Stooge;
2121
import org.apache.tapestry5.test.TapestryTestCase;
2222
import org.testng.annotations.Test;
2323

tapestry-core/src/test/java/org/apache/tapestry5/util/StringToEnumCoercionTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
package org.apache.tapestry5.util;
1616

1717
import junit.framework.AssertionFailedError;
18-
import org.apache.tapestry5.Stooge;
18+
19+
import org.apache.tapestry5.root.Stooge;
1920
import org.testng.Assert;
2021
import org.testng.annotations.Test;
2122

@@ -52,7 +53,7 @@ public void value_not_found()
5253
{
5354
assertEquals(
5455
ex.getMessage(),
55-
"Input \'shemp\' does not identify a value from enumerated type org.apache.tapestry5.Stooge. Available values: CURLY_JOE, LARRY, MOE.");
56+
"Input \'shemp\' does not identify a value from enumerated type org.apache.tapestry5.root.Stooge. Available values: CURLY_JOE, LARRY, MOE.");
5657
}
5758
}
5859
}

tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumLauncher.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public class SeleniumLauncher
9797
* <tr>
9898
* <td>port</td>
9999
* <td>tapestry.port</td>
100-
* <td>9999</td>
100+
* <td>9090</td>
101101
* <td>Port number for web server to listen to</td>
102102
* </tr>
103103
* <tr>
@@ -131,7 +131,7 @@ public synchronized void startup(
131131
@Optional("")
132132
String contextPath,
133133

134-
@Optional("9999")
134+
@Optional("9090")
135135
int port,
136136

137137
@Optional("*firefox")

0 commit comments

Comments
 (0)