Fix smtp block with python3 #10
Conversation
vad
left a comment
vad
left a comment
There was a problem hiding this comment.
requires a small refactoring to avoid code duplication
| def block_smtp(whitelist): | ||
| def whitelisted(self, host, *args, **kwargs): | ||
| if isinstance(host, basestring) and host not in whitelist: | ||
| try: |
There was a problem hiding this comment.
can you move this to the module level and reuse it in block_http?
|
@adamchainz there's no |
|
|
|
👍 to "it'll will make removal easier" |
|
Six would be a more expicit way to say: This conditional code is here because of 2-3 compatibility. It is easier to find all instances and remove them when we stop supporting python 2. Which won't be soon. |
4 participants
No description provided.