Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt doesn't bring up the menu anymore #219

Open
rmottola opened this issue Sep 24, 2024 · 6 comments
Open

alt doesn't bring up the menu anymore #219

rmottola opened this issue Sep 24, 2024 · 6 comments
Labels
hack A workaround has been found, but not a clean solution.

Comments

@rmottola
Copy link
Owner

at some point it broke, if the app-menu is used, alt should show the menu, but doesn't anymore.
@rmottola
Copy link
Owner Author

rmottola commented Oct 9, 2024 •
edited
Loading

Breaking commit

commit 2bbcbc81a2968c53015d68ced08e2638a83ad62e (HEAD)
Author: Riccardo Mottola <[email protected]>
Date:   Tue Aug 6 10:08:54 2024 +0200

    Bug 1192655 - Make menubar not react to events when it is not visible. r=enn

@rmottola
Copy link
Owner Author

rmottola commented Oct 9, 2024

@roytam1 do you notice this on windows? use in-app menu and then try alt-f. It stopped working on linux after this commit, which looks legit. I wonder if some css properties in menu or browser are missing....
On mac it has no meaning, menubar is handled differently.

@rmottola
Copy link
Owner Author

rmottola commented Oct 9, 2024

https://bugzilla.mozilla.org/attachment.cgi?id=8650807&action=edit

@roytam1
Copy link

roytam1 commented Oct 9, 2024

@roytam1 do you notice this on windows?

sure, and it seems to be existed for quite a long time.

@rmottola
Copy link
Owner Author

@roytam1 given my bisecting it exists since August 6. Does a revert help on windows? Do you get why? I think the patch is legit and tries to address full-screen issues, but something else is missing.

rmottola added a commit that referenced this issue Jan 4, 2025
@rmottola
Due to #219 Revert "Bug 1192655 - Make menubar not react to events wh…
7058bf3 
…en it is not visible. r=enn"
@rmottola
Copy link
Owner Author

rmottola commented Jan 4, 2025

@roytam1 I reverted the commit for now, could not understand what is wrong.

@rmottola rmottola added the hack A workaround has been found, but not a clean solution. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hack A workaround has been found, but not a clean solution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roytam1 @rmottola