Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default location of dump file #222

Open
fhs opened this issue May 13, 2019 · 4 comments
Open

Default location of dump file #222

fhs opened this issue May 13, 2019 · 4 comments

Comments

@fhs
Copy link
Contributor

fhs commented May 13, 2019

Currently, we're using $HOME/edwood.dump, which is not very portable. We can use os.UserHomeDir (added in Go 1.12) but I think it'll be better to eventually use os.UserConfigDir, which will be in Go 1.13.

@paul-lalonde
Copy link
Collaborator

paul-lalonde commented May 13, 2019 via email

@fhs
Copy link
Contributor Author

fhs commented May 13, 2019

Current directory may not be writable? I recently broke the -l flag, so you may be experiencing that. I'll send a fix shortly.

@paul-lalonde
Copy link
Collaborator

paul-lalonde commented May 13, 2019 via email

@fhs
Copy link
Contributor Author

fhs commented May 14, 2019

re-dumped to the same dump file as named in -l

I'm in favor of this. Most of the time you probably want to dump to the same file you loaded from. The -l flag behavior should be changed from "do initial load from this dump file" to "change default dump file to this".

fhs added a commit to fhs/edwood that referenced this issue Sep 24, 2019
os.UserHomeDir() was introduced in Go 1.12.

Update rjkroege#222
rjkroege pushed a commit that referenced this issue Sep 26, 2019
os.UserHomeDir() was introduced in Go 1.12.

Update #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants