Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing relocation types & architectures for ELF #4699

Open
Roeegg2 opened this issue Nov 3, 2024 · 3 comments
Open

Add missing relocation types & architectures for ELF #4699

Roeegg2 opened this issue Nov 3, 2024 · 3 comments
Labels
Milestone

Comments

@Roeegg2
Copy link
Contributor

Roeegg2 commented Nov 3, 2024

Is your feature request related to a problem? Please describe.
The code under file librz/bin/p/bin_elf.inc function reloc_convert which takes care of moving data from RzBinElfReloc to the general RzBinReloc doesn't take care of some relocation architectures (CRIS, Nios II, HPPA, and many more) and as well misses many relocation types in all of the currently implemented relocations

Describe the solution you'd like
Simply adding switches/cases to reloc_convert take of these architectures/types

Describe alternatives you've considered
N/A

Additional context
N/A

@Roeegg2
Copy link
Contributor Author

Roeegg2 commented Nov 4, 2024

Same thing for patch_reloc. A lot types and archs aren't handled there

@Rot127 Rot127 added RzBin ELF good first issue Good for newcomers labels Nov 4, 2024
@XVilka
Copy link
Member

XVilka commented Nov 4, 2024

HPPA will be covered by #4469

@Roeegg2
Copy link
Contributor Author

Roeegg2 commented Nov 5, 2024

We need to add the missing architectures and types in COFF as well... Maybe we should just unite them into one issue?
Both shouldn't take very long and aren't very hard to fix.

@XVilka XVilka added this to the 0.9.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants