Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error logging for aws sdk err #10993

Closed
xxchan opened this issue Jul 17, 2023 · 7 comments
Closed

improve error logging for aws sdk err #10993

xxchan opened this issue Jul 17, 2023 · 7 comments

Comments

@xxchan
Copy link
Member

xxchan commented Jul 17, 2023

Display of SdkError is very simple, and not helpful at all for diagnosing problem:

ERROR: ExecuteError: internal error: connector error: failed to construct request

{:?} is more informative, but less readable.

The recommended way is:

https://docs.rs/aws-smithy-http/latest/aws_smithy_http/result/enum.SdkError.html

When logging an error from the SDK, it is recommended that you either wrap the error in DisplayErrorContext, use another error reporter library that visits the error’s cause/source chain, or call Error::source for more details about the underlying cause.

@github-actions github-actions bot added this to the release-1.0 milestone Jul 17, 2023
@fuyufjh fuyufjh modified the milestones: release-1.0, release-1.1 Jul 18, 2023
@xxchan
Copy link
Member Author

xxchan commented Jul 18, 2023

Note: We have much nicer error message in v0.19, e.g.,
image

The regression in v1.0 is because we upgraded aws sdk.

@xxchan
Copy link
Member Author

xxchan commented Jul 18, 2023

@xxchan
Copy link
Member Author

xxchan commented Jul 18, 2023

@xxchan
Copy link
Member Author

xxchan commented Jul 27, 2023

https://risingwave-community.slack.com/archives/C03BW71523T/p1690455709545769 Another trouble due to error message.

@xxchan
Copy link
Member Author

xxchan commented Jul 27, 2023

s3 source error improved in #11120

@xxchan
Copy link
Member Author

xxchan commented Jul 27, 2023

#11198 also related

@xxchan
Copy link
Member Author

xxchan commented Aug 1, 2023

most important parts fixed. fix more in future on demand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants