fix: Parsing programs with integers that overflow a u64 will no longer panic; instead, they will raise an error. (#372)

* fix: Parsing programs with integers that overflow a u64 will no longer panic; instead, they will raise an error.

* make MemoryAccess pub to appease clippy

* map

Co-authored-by: Michael Bryant <[email protected]>

* rustfmt

---------

Co-authored-by: Michael Bryant <[email protected]>

Author: MarquessV

quil-rs/src/parser/lexer/error.rs

@@ -33,4 +33,6 @@ pub enum LexErrorKind {
     /// Encountered an unexpected EOF
     #[error("unexpected EOF while parsing")]
     UnexpectedEOF,
+    #[error("error parsing an integer: {0}")]
+    ParseInt(#[from] std::num::ParseIntError),
 }

quil-rs/src/parser/lexer/mod.rs

@@ -297,7 +297,11 @@ fn lex_number(input: LexInput) -> InternalLexResult {
     Ok((
         input,
         match integer_parse_result {
-            Ok(_) => Token::Integer(float_string.parse::<u64>().unwrap()),
+            Ok(_) => float_string
+                .parse::<u64>()
+                .map(Token::Integer)
+                .map_err(|e| InternalLexError::from_kind(input, e.into()))
+                .map_err(nom::Err::Failure)?,
             Err(_) => Token::Float(double(float_string)?.1),
         },
     ))

quil-rs/src/program/mod.rs

@@ -34,7 +34,7 @@ pub use self::calibration_set::CalibrationSet;
 pub use self::error::{disallow_leftover, map_parsed, recover, ParseProgramError, SyntaxError};
 pub use self::frame::FrameSet;
 pub use self::frame::MatchedFrames;
-pub use self::memory::{MemoryAccesses, MemoryRegion};
+pub use self::memory::{MemoryAccess, MemoryAccesses, MemoryRegion};
 
 pub mod analysis;
 mod calibration;