Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dodgr automatically removing impassable routes for given wt_profile? #38

Open
MilesMcBain opened this issue Aug 13, 2019 · 3 comments
Open

Comments

@MilesMcBain
Copy link

Thanks for this excellent resource. I am currently working through a similar workflow for analysing the effects of relocating a fire station in Queesnland.

In Catchment Zones, Step 8 the following statement is made:

The resultant network has a d_weighted column which preferentially weights the distances for the nominated mode of tranport. Those parts of the network which are unsuitable for vehicular transport have values of .Machine$double.xmax = r .Machine$double.xmax. Because we want to align our random points to the routable component of the network, these need to be removed.

net <- net [which (net$d_weighted < .Machine$double.xmax), ]
nrow (net)
#> [1] 293853

I've found that on a different street network in Queensland, this step had no effect, as weight_streetnet() has dropped edges which were impassable for "motorvehicle". I've verified this by comparing the values of way_id present in the weighted network with the osm_id in the streetnet downloaded using dodgr_streetnet().

Is this step no longer requried? I couldn't find any reference to it in the dodgr NEWS file.

@mpadge
Copy link
Collaborator

mpadge commented Aug 13, 2019

Thanks Miles, and thanks for the usage and positive feedback. I'll check it out asap. Congrats on your job too - Nick told me about it, sounds great!

@mpadge
Copy link
Collaborator

mpadge commented Aug 13, 2019

Ah, yeah, you're right @MilesMcBain, that step is no longer necessary, because of this line, which was buried in this commit while my head was full of other ideas. Sorry about that. (Auto-removal of non-routable ways is also implemented for sc format with time-based routing.)

@richardbeare @GNtem2 Is the idea now that we update the site on an ongoing basis? Should I amend accordingly? If Yes and Yes, then I'll do a PR with updated description following the comments of @MilesMcBain. Thanks Miles!

@richardbeare
Copy link
Owner

I think we should aim to keep the web site working with current versions of the packages, so yes, please update and send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants